[
https://issues.apache.org/jira/browse/BEAM-10139?focusedWorklogId=477860&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-477860
]
ASF GitHub Bot logged work on BEAM-10139:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Sep/20 13:31
Start Date: 02/Sep/20 13:31
Worklog Time Spent: 10m
Work Description: piotr-szuberski commented on a change in pull request
#12611:
URL: https://github.com/apache/beam/pull/12611#discussion_r482070325
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
##########
@@ -678,6 +703,42 @@ public Read withPartitionOptions(PartitionOptions
partitionOptions) {
.withTransaction(getTransaction());
return input.apply(Create.of(getReadOperation())).apply("Execute query",
readAll);
}
+
+ SerializableFunction<Struct, Row> getFormatFn() {
+ return (SerializableFunction<Struct, Row>)
+ input ->
+ Row.withSchema(Schema.builder().addInt64Field("Key").build())
+ .withFieldValue("Key", 3L)
+ .build();
+ }
+ }
+
+ public static class ReadRows extends PTransform<PBegin, PCollection<Row>> {
+ Read read;
+ Schema schema;
+
+ public ReadRows(Read read, Schema schema) {
+ super("Read rows");
+ this.read = read;
+ this.schema = schema;
+ }
+
+ @Override
+ public PCollection<Row> expand(PBegin input) {
+ return input
+ .apply(read)
+ .apply(
+ MapElements.into(TypeDescriptor.of(Row.class))
+ .via(
+ new SerializableFunction<Struct, Row>() {
+ @Override
+ public Row apply(Struct struct) {
+ return StructUtils.translateStructToRow(struct,
schema);
+ }
+ }))
+ .setRowSchema(schema)
+ .setCoder(RowCoder.of(schema));
Review comment:
For some reason it was not obvious to me. Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 477860)
Time Spent: 1h 50m (was: 1h 40m)
> Add cross-language wrapper for Java's SpannerIO Write
> -----------------------------------------------------
>
> Key: BEAM-10139
> URL: https://issues.apache.org/jira/browse/BEAM-10139
> Project: Beam
> Issue Type: Sub-task
> Components: cross-language, io-java-gcp, io-py-gcp
> Affects Versions: Not applicable
> Reporter: Piotr Szuberski
> Assignee: Piotr Szuberski
> Priority: P2
> Labels: portability
> Fix For: Not applicable
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Add cross-language wrapper for Java's SpannerIO Write
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
