[
https://issues.apache.org/jira/browse/BEAM-10824?focusedWorklogId=478000&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-478000
]
ASF GitHub Bot logged work on BEAM-10824:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Sep/20 17:47
Start Date: 02/Sep/20 17:47
Worklog Time Spent: 10m
Work Description: monicadsong edited a comment on pull request #12756:
URL: https://github.com/apache/beam/pull/12756#issuecomment-685895179
R:@tvalentyn-- I can't seem to pass the codecov/patch report, but have added
unit tests for the combiner that should go through the paths that are
highlighted. Also,I think the other 3 failing tests failing for other merged
PR's as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 478000)
Remaining Estimate: 20h 40m (was: 20h 50m)
Time Spent: 3h 20m (was: 3h 10m)
> Hash in stats.ApproximateUniqueCombineFn NON-deterministic
> ----------------------------------------------------------
>
> Key: BEAM-10824
> URL: https://issues.apache.org/jira/browse/BEAM-10824
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Monica Song
> Priority: P1
> Labels: hash
> Original Estimate: 24h
> Time Spent: 3h 20m
> Remaining Estimate: 20h 40m
>
> The python hash() function is non-deterministic. As a result, different
> workers will map identical values to different hashes. This leads to
> overestimation of the number of unique values (by several magnitudes, in my
> experience x1000) in a distributed processing model.
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/transforms/stats.py#L218]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
