[
https://issues.apache.org/jira/browse/BEAM-6472?focusedWorklogId=187417&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-187417
]
ASF GitHub Bot logged work on BEAM-6472:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jan/19 20:08
Start Date: 19/Jan/19 20:08
Worklog Time Spent: 10m
Work Description: angoenka commented on pull request #7573: [BEAM-6472]
Set read permissions for the staged files
URL: https://github.com/apache/beam/pull/7573#discussion_r249256006
##########
File path: sdks/python/apache_beam/runners/portability/portable_stager.py
##########
@@ -71,7 +71,8 @@ def stage_artifact(self, local_path_to_artifact,
artifact_name):
def artifact_request_generator():
artifact_metadata = beam_artifact_api_pb2.ArtifactMetadata(
name=artifact_name,
- sha256=_get_file_hash(local_path_to_artifact))
+ sha256=_get_file_hash(local_path_to_artifact),
+ permissions=444)
Review comment:
Artifact retrieval service download and create artifact on sdk harness and
sets the file permission based on metadata here
https://github.com/apache/beam/blob/7b9fd010886f2bb2bc0cec552666b1b35a59324f/sdks/go/pkg/beam/artifact/materialize.go#L153
As we don't pass any permission, no permissions are set on file creation at
the time of retrieval.
If SDK Harness is not executed as root which is the most common case in non
dokorized environment, artifacts can not be read.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 187417)
Time Spent: 0.5h (was: 20m)
> Artifact staging permissions are not set while staging python artifacts
> -----------------------------------------------------------------------
>
> Key: BEAM-6472
> URL: https://issues.apache.org/jira/browse/BEAM-6472
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-harness
> Reporter: Ankur Goenka
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We need to pass the read permissions for the artifacts so that the artifacts
> can be read by the pip and installed.
> Inside docker this is not an issue as docker runs are root. However when
> using other types of environment which do not run as root, artifact access
> will not be possible without the right permissions.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
