[
https://issues.apache.org/jira/browse/BEAM-10139?focusedWorklogId=478518&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-478518
]
ASF GitHub Bot logged work on BEAM-10139:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Sep/20 12:14
Start Date: 03/Sep/20 12:14
Worklog Time Spent: 10m
Work Description: piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-686447747
@TheNeuralBit I've upgraded it a bit.
- Checking schemas equality is redundant because it will throw an exception
with a good message anyway (class cast failure or unknown column).
- I managed to unify addArray and addIterable code duplication with a bit
ugly casts (needed SuppressWarning("unchecked")) but I don't think it can be
easily achieved otherwise.
- Nothing comes to my mind to remove duplication in
addIterableToMutationBuilder and addIterableToStructBuilder methods. These are
unrelated classes (Struct.Builder and Mutation.WriteBuilder. Maybe my Java
knowledge is insufficient here. I could make an interface that simulates
.setInt64Array, setStructArray etc but it would be even more boilerplate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 478518)
Time Spent: 4h 50m (was: 4h 40m)
> Add cross-language wrapper for Java's SpannerIO Write
> -----------------------------------------------------
>
> Key: BEAM-10139
> URL: https://issues.apache.org/jira/browse/BEAM-10139
> Project: Beam
> Issue Type: Sub-task
> Components: cross-language, io-java-gcp, io-py-gcp
> Affects Versions: Not applicable
> Reporter: Piotr Szuberski
> Assignee: Piotr Szuberski
> Priority: P2
> Labels: portability
> Fix For: Not applicable
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Add cross-language wrapper for Java's SpannerIO Write
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
