[ 
https://issues.apache.org/jira/browse/BEAM-10615?focusedWorklogId=478656&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-478656
 ]

ASF GitHub Bot logged work on BEAM-10615:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Sep/20 15:55
            Start Date: 03/Sep/20 15:55
    Worklog Time Spent: 10m 
      Work Description: TheNeuralBit commented on a change in pull request 
#12738:
URL: https://github.com/apache/beam/pull/12738#discussion_r483084816



##########
File path: 
sdks/java/extensions/sql/jdbc/src/test/java/org/apache/beam/sdk/extensions/sql/jdbc/BeamSqlLineIT.java
##########
@@ -198,12 +202,15 @@ private String taxiRideJSON(
     return objectNode.toString();
   }
 
+  /** Suppressing this due to 
https://github.com/typetools/checker-framework/issues/979. */
+  @SuppressWarnings("return.type.incompatible")
   private Future<List<List<String>>> runQueryInBackground(String[] args) {
     return pool.submit(
         (Callable)
             () -> {
               ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
-              BeamSqlLine.runSqlLine(args, null, outputStream, null);
+              InputStream inputStream = new ByteArrayInputStream(new byte[0]);
+              BeamSqlLine.runSqlLine(args, inputStream, outputStream, null);

Review comment:
       Thank you! yeah the github actions tests on different targets seem to 
flake pretty often and I'm not sure how to re-run them. I think its safe to 
ignore.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 478656)
    Time Spent: 3h  (was: 2h 50m)

> Eliminate nullability errors from :sdks:java:extensions:sql:jdbc
> ----------------------------------------------------------------
>
>                 Key: BEAM-10615
>                 URL: https://issues.apache.org/jira/browse/BEAM-10615
>             Project: Beam
>          Issue Type: Sub-task
>          Components: dsl-sql
>            Reporter: Jayendra
>            Assignee: Jayendra
>            Priority: P2
>              Labels: starter
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> Just edit {{build.gradle}} and set {{enableChecker: true}} and fix some 
> errors!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to