[
https://issues.apache.org/jira/browse/BEAM-10760?focusedWorklogId=480159&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-480159
]
ASF GitHub Bot logged work on BEAM-10760:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Sep/20 14:09
Start Date: 08/Sep/20 14:09
Worklog Time Spent: 10m
Work Description: tweise commented on a change in pull request #12759:
URL: https://github.com/apache/beam/pull/12759#discussion_r484949923
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/state/FlinkStateInternals.java
##########
@@ -114,16 +129,26 @@ public K getKey() {
return address.getSpec().bind(address.getId(), new
FlinkStateBinder(namespace, context));
}
- public void clearBagStates(StateNamespace namespace, StateTag<? extends
BagState> address)
- throws Exception {
- CoderTypeSerializer typeSerializer = new
CoderTypeSerializer<>(VoidCoder.of());
- flinkStateBackend.applyToAllKeys(
- namespace.stringKey(),
- StringSerializer.INSTANCE,
- new ListStateDescriptor<>(address.getId(), typeSerializer),
- (key, state) -> {
- state.clear();
- });
+ /**
+ * Allows to clear all state for the global watermark when the maximum
watermark arrives. We do
+ * not clean up the global window state via timers which would lead to an
unbounded number of keys
+ * and cleanup timers. Instead, the cleanup code below should be run when we
finally receive the
+ * max watermark.
+ */
+ public void clearGlobalState() {
Review comment:
Doesn't need to be public?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 480159)
Time Spent: 5h 40m (was: 5.5h)
> Cleanup timers lead to unbounded state accumulation in global window
> --------------------------------------------------------------------
>
> Key: BEAM-10760
> URL: https://issues.apache.org/jira/browse/BEAM-10760
> Project: Beam
> Issue Type: Bug
> Components: runner-core, runner-flink
> Affects Versions: 2.21.0
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: P2
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> For each key, the runner sets a cleanup timer that is designed to garbage
> collect state at the end of a window. For a global window, these timers will
> stay around until the pipeline terminates. Depending on the key cardinality,
> this can lead to unbounded state growth, which in the case of the Flink
> runner is observable in the growth of checkpoint size.
> https://lists.apache.org/thread.html/rae268806035688b77646195505e5b7a56568a38feb1e52d6341feedd%40%3Cdev.beam.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
