[
https://issues.apache.org/jira/browse/BEAM-10326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192321#comment-17192321
]
Beam JIRA Bot commented on BEAM-10326:
--------------------------------------
This issue was marked "stale-P2" and has not received a public comment in 14
days. It is now automatically moved to P3. If you are still affected by it, you
can comment and move it back to P2.
> Combine API to increase safety when accumulator is mutated
> ----------------------------------------------------------
>
> Key: BEAM-10326
> URL: https://issues.apache.org/jira/browse/BEAM-10326
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Priority: P3
>
> Combine docs for e.g. {{mergeAccumulators}} say
> "only the first accumulator may be modified and returned for efficiency; the
> other accumulators should not be mutated, because they may be shared with
> other code and mutating them could lead to incorrect results or data
> corruption."
> This is fine, but the API is odd: {{AccumT mergeAccumulators(Iterable<AccumT>
> accumulators)}} implies that all accumulators are treated equally.
> It has been suggested to create a new one more like {{AccumT
> mergeAccumulators(AccumT mutable, Iterable<AccumT> immutableAccums)}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
