[
https://issues.apache.org/jira/browse/BEAM-7009?focusedWorklogId=481047&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-481047
]
ASF GitHub Bot logged work on BEAM-7009:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/20 20:29
Start Date: 09/Sep/20 20:29
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #12588:
URL: https://github.com/apache/beam/pull/12588#issuecomment-689776953
# [Codecov](https://codecov.io/gh/apache/beam/pull/12588?src=pr&el=h1) Report
> Merging
[#12588](https://codecov.io/gh/apache/beam/pull/12588?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/beam/commit/4635afbf686b216983d1c0552b33cd435f922812?el=desc)
will **decrease** coverage by `0.04%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/beam/pull/12588?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12588 +/- ##
==========================================
- Coverage 40.42% 40.38% -0.05%
==========================================
Files 450 451 +1
Lines 53665 53721 +56
==========================================
Hits 21696 21696
- Misses 31969 32025 +56
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/12588?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[...apache\_beam/runners/dataflow/internal/apiclient.py](https://codecov.io/gh/apache/beam/pull/12588/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9hcGljbGllbnQucHk=)
| `20.20% <0.00%> (ø)` | |
|
[...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12588/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==)
| `28.06% <0.00%> (+0.04%)` | :arrow_up: |
|
[...eam/testing/benchmarks/nexmark/nexmark\_launcher.py](https://codecov.io/gh/apache/beam/pull/12588/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19sYXVuY2hlci5weQ==)
| `0.00% <0.00%> (ø)` | |
|
[...he\_beam/testing/benchmarks/nexmark/nexmark\_perf.py](https://codecov.io/gh/apache/beam/pull/12588/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19wZXJmLnB5)
| `0.00% <0.00%> (ø)` | |
|
[...he\_beam/testing/benchmarks/nexmark/nexmark\_util.py](https://codecov.io/gh/apache/beam/pull/12588/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya191dGlsLnB5)
| `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/12588?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/12588?src=pr&el=footer). Last
update
[6213d47...01095f0](https://codecov.io/gh/apache/beam/pull/12588?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 481047)
Time Spent: 2h (was: 1h 50m)
> Add Go SDK test for Standard Coders using the yaml data.
> --------------------------------------------------------
>
> Key: BEAM-7009
> URL: https://issues.apache.org/jira/browse/BEAM-7009
> Project: Beam
> Issue Type: Bug
> Components: beam-model, sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P1
> Labels: stale-P2
> Time Spent: 2h
> Remaining Estimate: 0h
>
> The Go SDK doesn't currently do this validation, against the standard yaml
> file. [1]
> The Java and Python equivalents of the test can be found from here [2].
>
> Care would need to be taken so that Beam Go SDK users (such as they are)
> aren't forced to run them, and not have the yaml file to read. I'd suggest
> putting it with the integration tests [3].
> The other thing of note is that the Go SDK has no notion of "nested" vs
> "unnested" coders. All coders are "nested" in the Go SDK, and should have
> their lengths prefixed to them as appropriate.
> 1:
> [https://github.com/apache/beam/blob/master/model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml]
> 2:
> [https://github.com/apache/beam/search?q=standard_coders.yaml&unscoped_q=standard_coders.yaml]
> 3: [https://github.com/apache/beam/tree/master/sdks/go/test
> |https://github.com/apache/beam/tree/master/sdks/go/test]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
