[ 
https://issues.apache.org/jira/browse/BEAM-9456?focusedWorklogId=481055&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-481055
 ]

ASF GitHub Bot logged work on BEAM-9456:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Sep/20 20:54
            Start Date: 09/Sep/20 20:54
    Worklog Time Spent: 10m 
      Work Description: runningcode commented on a change in pull request 
#12776:
URL: https://github.com/apache/beam/pull/12776#discussion_r485916221



##########
File path: runners/flink/build.gradle
##########
@@ -0,0 +1,32 @@
+/*

Review comment:
       This is an optimization, but it is also required in order to update the 
spotless version which is required in order to bump the Gradle version.
   
   In the new version of spotless, all target files must be in the project root 
which means they can't be added to the buildscripts in the `runners/flink/1.10` 
subdirectories.
   
https://github.com/diffplug/spotless/blob/main/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTaskImpl.java#L106
   
   See [this PR](https://github.com/apache/beam/pull/12777) and [this build 
scan for more 
info](https://scans.gradle.com/s/mwcogpdbedf7a/failure?anchor=e30&focused-exception-line=0-4-0#1)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 481055)
    Time Spent: 7h 20m  (was: 7h 10m)

> Upgrade to gradle 6.6.0
> -----------------------
>
>                 Key: BEAM-9456
>                 URL: https://issues.apache.org/jira/browse/BEAM-9456
>             Project: Beam
>          Issue Type: Task
>          Components: build-system
>            Reporter: Alex Van Boxel
>            Assignee: Kamil GaƂuszka
>            Priority: P2
>          Time Spent: 7h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to