[
https://issues.apache.org/jira/browse/BEAM-5953?focusedWorklogId=188047&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188047
]
ASF GitHub Bot logged work on BEAM-5953:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/19 08:49
Start Date: 22/Jan/19 08:49
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #7521: [BEAM-5953]
Fix py3 type error in bundle_processor
URL: https://github.com/apache/beam/pull/7521#discussion_r248993766
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -591,8 +592,10 @@ def get_coder(self, coder_id):
return self.context.coders.get_by_id(coder_id)
else:
# No URN, assume cloud object encoding json bytes.
- return operation_specs.get_coder_from_spec(
- json.loads(coder_proto.spec.spec.payload))
+ payload = coder_proto.spec.spec.payload
+ if isinstance(payload, bytes) and sys.version_info[0] == 3:
Review comment:
Of course what would be better is if the Dataflow runner harness was fixed
to *always* use proper coder URNs rather than stuffing json-ized dataflow v1b3
cloud proto representations into the payload. Can you find/file a JIRA for
this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 188047)
Time Spent: 3h 50m (was: 3h 40m)
> Support DataflowRunner on Python 3
> ----------------------------------
>
> Key: BEAM-5953
> URL: https://issues.apache.org/jira/browse/BEAM-5953
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Mark Liu
> Assignee: Mark Liu
> Priority: Major
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
