[
https://issues.apache.org/jira/browse/BEAM-10824?focusedWorklogId=481704&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-481704
]
ASF GitHub Bot logged work on BEAM-10824:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/20 21:20
Start Date: 10/Sep/20 21:20
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #12756:
URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075
# [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr&el=h1) Report
> Merging
[#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/beam/commit/f923da12e02e233d8c40b28d520c49886b1adca4?el=desc)
will **increase** coverage by `41.80%`.
> The diff coverage is `86.36%`.
[](https://codecov.io/gh/apache/beam/pull/12756?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12756 +/- ##
===========================================
+ Coverage 40.23% 82.04% +41.80%
===========================================
Files 455 457 +2
Lines 53729 54086 +357
===========================================
+ Hits 21620 44373 +22753
+ Misses 32109 9713 -22396
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/12756?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/transforms/stats.py](https://codecov.io/gh/apache/beam/pull/12756/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9zdGF0cy5weQ==)
| `87.39% <86.36%> (+60.06%)` | :arrow_up: |
|
[sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12756/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=)
| `100.00% <0.00%> (ø)` | |
|
[...he\_beam/testing/benchmarks/nexmark/nexmark\_util.py](https://codecov.io/gh/apache/beam/pull/12756/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya191dGlsLnB5)
| `0.00% <0.00%> (ø)` | |
|
[...eam/testing/benchmarks/nexmark/nexmark\_launcher.py](https://codecov.io/gh/apache/beam/pull/12756/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19sYXVuY2hlci5weQ==)
| `0.00% <0.00%> (ø)` | |
|
[sdks/python/apache\_beam/utils/histogram.py](https://codecov.io/gh/apache/beam/pull/12756/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaGlzdG9ncmFtLnB5)
| `94.28% <0.00%> (ø)` | |
|
[...he\_beam/testing/benchmarks/nexmark/nexmark\_perf.py](https://codecov.io/gh/apache/beam/pull/12756/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19wZXJmLnB5)
| `0.00% <0.00%> (ø)` | |
|
[sdks/python/apache\_beam/coders/slow\_stream.py](https://codecov.io/gh/apache/beam/pull/12756/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Nsb3dfc3RyZWFtLnB5)
| `92.43% <0.00%> (+1.68%)` | :arrow_up: |
|
[sdks/python/apache\_beam/utils/profiler.py](https://codecov.io/gh/apache/beam/pull/12756/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvZmlsZXIucHk=)
| `32.11% <0.00%> (+1.83%)` | :arrow_up: |
|
[...on/apache\_beam/runners/direct/sdf\_direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12756/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3Qvc2RmX2RpcmVjdF9ydW5uZXIucHk=)
| `36.21% <0.00%> (+2.46%)` | :arrow_up: |
|
[sdks/python/apache\_beam/coders/coder\_impl.py](https://codecov.io/gh/apache/beam/pull/12756/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyX2ltcGwucHk=)
| `95.25% <0.00%> (+2.64%)` | :arrow_up: |
| ... and [274
more](https://codecov.io/gh/apache/beam/pull/12756/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr&el=footer). Last
update
[31af8b1...fa23439](https://codecov.io/gh/apache/beam/pull/12756?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 481704)
Remaining Estimate: 6h 50m (was: 7h)
Time Spent: 17h 10m (was: 17h)
> Hash in stats.ApproximateUniqueCombineFn NON-deterministic
> ----------------------------------------------------------
>
> Key: BEAM-10824
> URL: https://issues.apache.org/jira/browse/BEAM-10824
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Monica Song
> Priority: P1
> Labels: hash
> Original Estimate: 24h
> Time Spent: 17h 10m
> Remaining Estimate: 6h 50m
>
> The python hash() function is non-deterministic. As a result, different
> workers will map identical values to different hashes. This leads to
> overestimation of the number of unique values (by several magnitudes, in my
> experience x1000) in a distributed processing model.
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/transforms/stats.py#L218]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
