[
https://issues.apache.org/jira/browse/BEAM-10769?focusedWorklogId=481730&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-481730
]
ASF GitHub Bot logged work on BEAM-10769:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/20 22:03
Start Date: 10/Sep/20 22:03
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #12638:
URL: https://github.com/apache/beam/pull/12638#discussion_r486658612
##########
File path: sdks/python/apache_beam/io/avroio.py
##########
@@ -511,7 +488,9 @@ def __init__(
end in a common extension, if given by file_name_suffix. In most cases,
only this argument is specified and num_shards, shard_name_template,
and
file_name_suffix use default values.
- schema: The schema to use, as returned by avro.schema.Parse
+ schema: The schema to use (dict).
Review comment:
According to https://fastavro.readthedocs.io/en/latest/schema.html, it's
a dict.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 481730)
Time Spent: 1h 40m (was: 1.5h)
> Fix Avro IO documentation: when fastavro is used, do not pass schema parsed
> by avro-python3.
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-10769
> URL: https://issues.apache.org/jira/browse/BEAM-10769
> Project: Beam
> Issue Type: Bug
> Components: io-py-gcp
> Reporter: Valentyn Tymofieiev
> Assignee: Valentyn Tymofieiev
> Priority: P2
> Fix For: 2.25.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
