[
https://issues.apache.org/jira/browse/BEAM-10670?focusedWorklogId=481794&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-481794
]
ASF GitHub Bot logged work on BEAM-10670:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/20 23:51
Start Date: 10/Sep/20 23:51
Worklog Time Spent: 10m
Work Description: tysonjh commented on a change in pull request #12616:
URL: https://github.com/apache/beam/pull/12616#discussion_r486679831
##########
File path: runners/jet/build.gradle
##########
@@ -85,6 +84,12 @@ task validatesRunnerBatch(type: Test) {
excludeCategories
'org.apache.beam.sdk.testing.UsesTestStreamWithProcessingTime'
}
filter {
+ // There is an existing bug caused by Jet assuming that outputs
emitted are Object.equals comparable which is not true for byte[]
+ excludeTestsMatching
'org.apache.beam.sdk.transforms.SplittableDoFnTest.testOutputAfterCheckpointBounded'
+
+ // There is an existing bug where we are trying to add additional
outputs during flusing and don't restore state correctly
Review comment:
```suggestion
// There is an existing bug where we are trying to add additional
outputs during flushing and don't restore state correctly
```
##########
File path: runners/jet/src/main/java/org/apache/beam/runners/jet/JetRunner.java
##########
@@ -186,7 +189,15 @@ private JetInstance getJetInstance(JetPipelineOptions
options) {
}
private static List<PTransformOverride> getDefaultOverrides() {
- return Collections.emptyList();
+ return Arrays.asList(
Review comment:
Is this list exhaustive? How can I tell if something is missing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 481794)
Time Spent: 15h 10m (was: 15h)
> Make non-portable Splittable DoFn the only option when executing Java "Read"
> transforms
> ---------------------------------------------------------------------------------------
>
> Key: BEAM-10670
> URL: https://issues.apache.org/jira/browse/BEAM-10670
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: P2
> Time Spent: 15h 10m
> Remaining Estimate: 0h
>
> All runners seem to be capable of migrating to splittable DoFn for
> non-portable execution except for Dataflow runner v1 which will internalize
> the current primitive read implementation that is shared across runner
> implementations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
