[ 
https://issues.apache.org/jira/browse/BEAM-10873?focusedWorklogId=481805&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-481805
 ]

ASF GitHub Bot logged work on BEAM-10873:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Sep/20 00:22
            Start Date: 11/Sep/20 00:22
    Worklog Time Spent: 10m 
      Work Description: codecov[bot] edited a comment on pull request #12812:
URL: https://github.com/apache/beam/pull/12812#issuecomment-690611762


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12812?src=pr&el=h1) Report
   > Merging 
[#12812](https://codecov.io/gh/apache/beam/pull/12812?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/beam/commit/d2fc192335da01a442c2b208d437322bb1e868a8?el=desc)
 will **increase** coverage by `41.95%`.
   > The diff coverage is `92.53%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/beam/pull/12812/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12812?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #12812       +/-   ##
   ===========================================
   + Coverage   40.43%   82.39%   +41.95%     
   ===========================================
     Files         449      451        +2     
     Lines       53502    53808      +306     
   ===========================================
   + Hits        21635    44333    +22698     
   + Misses      31867     9475    -22392     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/beam/pull/12812?src=pr&el=tree) | Coverage 
Δ | |
   |---|---|---|
   | 
[sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/12812/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==)
 | `89.83% <83.33%> (+46.09%)` | :arrow_up: |
   | 
[sdks/python/apache\_beam/dataframe/expressions.py](https://codecov.io/gh/apache/beam/pull/12812/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2V4cHJlc3Npb25zLnB5)
 | `89.70% <96.29%> (+40.16%)` | :arrow_up: |
   | 
[sdks/python/apache\_beam/dataframe/doctests.py](https://codecov.io/gh/apache/beam/pull/12812/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2RvY3Rlc3RzLnB5)
 | `98.19% <100.00%> (+73.30%)` | :arrow_up: |
   | 
[sdks/python/apache\_beam/dataframe/frame\_base.py](https://codecov.io/gh/apache/beam/pull/12812/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lX2Jhc2UucHk=)
 | `86.14% <100.00%> (+34.61%)` | :arrow_up: |
   | 
[sdks/python/apache\_beam/dataframe/partitionings.py](https://codecov.io/gh/apache/beam/pull/12812/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL3BhcnRpdGlvbmluZ3MucHk=)
 | `89.04% <100.00%> (+39.86%)` | :arrow_up: |
   | 
[...he\_beam/testing/benchmarks/nexmark/nexmark\_util.py](https://codecov.io/gh/apache/beam/pull/12812/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya191dGlsLnB5)
 | `0.00% <0.00%> (ø)` | |
   | 
[...eam/testing/benchmarks/nexmark/nexmark\_launcher.py](https://codecov.io/gh/apache/beam/pull/12812/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19sYXVuY2hlci5weQ==)
 | `0.00% <0.00%> (ø)` | |
   | 
[sdks/python/apache\_beam/utils/histogram.py](https://codecov.io/gh/apache/beam/pull/12812/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaGlzdG9ncmFtLnB5)
 | `94.28% <0.00%> (ø)` | |
   | 
[...he\_beam/testing/benchmarks/nexmark/nexmark\_perf.py](https://codecov.io/gh/apache/beam/pull/12812/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19wZXJmLnB5)
 | `0.00% <0.00%> (ø)` | |
   | 
[sdks/python/apache\_beam/coders/slow\_stream.py](https://codecov.io/gh/apache/beam/pull/12812/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Nsb3dfc3RyZWFtLnB5)
 | `92.43% <0.00%> (+1.68%)` | :arrow_up: |
   | ... and [276 
more](https://codecov.io/gh/apache/beam/pull/12812/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/beam/pull/12812?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/beam/pull/12812?src=pr&el=footer). Last 
update 
[d2fc192...304ce82](https://codecov.io/gh/apache/beam/pull/12812?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 481805)
    Time Spent: 1h 20m  (was: 1h 10m)

> Stronger testing of dataframes partitioning declartions.
> --------------------------------------------------------
>
>                 Key: BEAM-10873
>                 URL: https://issues.apache.org/jira/browse/BEAM-10873
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robert Bradshaw
>            Assignee: Robert Bradshaw
>            Priority: P2
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> This would better detect issues like that discovered in 
> https://github.com/apache/beam/pull/12676



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to