[
https://issues.apache.org/jira/browse/BEAM-4472?focusedWorklogId=188382&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188382
]
ASF GitHub Bot logged work on BEAM-4472:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/19 18:04
Start Date: 22/Jan/19 18:04
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #7586: [BEAM-4472]
Fix Top accum coder to be liftable.
URL: https://github.com/apache/beam/pull/7586
Top wasn't written correctly initially (it predates much of the execution
engine), and wasn't written to be liftable. This changes MergeAccumulators to
use a binary transform, and adds a custom encoding for the accumulator type
using the JSON override mechanism.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/)
| --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 188382)
Time Spent: 10m
Remaining Estimate: 0h
> Go SDK - Rewrite top.go accumulator to be encodable.
> ----------------------------------------------------
>
> Key: BEAM-4472
> URL: https://issues.apache.org/jira/browse/BEAM-4472
> Project: Beam
> Issue Type: Bug
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Related to, but does not require, BEAM-4276 to be completed first.
> An unencodable accumulator type prevents the Top combination from being
> lifted, as in a lifted combine, the accumulator type is used in a GBK.
> The accumulator type current contains a field of []interface{} which is not
> an encodable type.
> Ideally, such an implementation will not constantly decode > process element
> > reencode when processing elements for comparison.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
