[
https://issues.apache.org/jira/browse/BEAM-6483?focusedWorklogId=188413&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188413
]
ASF GitHub Bot logged work on BEAM-6483:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/19 18:30
Start Date: 22/Jan/19 18:30
Worklog Time Spent: 10m
Work Description: sekikn commented on pull request #7587: [BEAM-6483] Add
support for SADD operation to RedisIO.Write
URL: https://github.com/apache/beam/pull/7587
For now, RedisIO.Write supports write methods for string (APPEND, SET),
list (LPUSH, RPUSH) and HyperLogLog (PFADD), but not for set (SADD).
This PR adds it. In addition, I did the following refactoring in this:
* make the input value check for port number stricter
* replace a magic number indicating the end of a loop with a constant
* remove an unnecessary argument from writeUsingHLLCommand,
which is a private method used only internally
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/)
| --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 188413)
Time Spent: 10m
Remaining Estimate: 0h
> Add support for SADD operation to RedisIO.Write
> -----------------------------------------------
>
> Key: BEAM-6483
> URL: https://issues.apache.org/jira/browse/BEAM-6483
> Project: Beam
> Issue Type: Improvement
> Components: io-java-redis
> Reporter: Kengo Seki
> Assignee: Kengo Seki
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> For now, RedisIO.Write supports write methods for string (APPEND, SET), list
> (LPUSH, RPUSH) and HyperLogLog (PFADD), but not for set (SADD).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
