[
https://issues.apache.org/jira/browse/BEAM-10009?focusedWorklogId=482156&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-482156
]
ASF GitHub Bot logged work on BEAM-10009:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Sep/20 16:29
Start Date: 11/Sep/20 16:29
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #12764:
URL: https://github.com/apache/beam/pull/12764#issuecomment-686100810
# [Codecov](https://codecov.io/gh/apache/beam/pull/12764?src=pr&el=h1) Report
> Merging
[#12764](https://codecov.io/gh/apache/beam/pull/12764?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/beam/commit/9f4d54a2e60ec45150437c0b050f4c73cca91f36?el=desc)
will **increase** coverage by `41.81%`.
> The diff coverage is `87.50%`.
[](https://codecov.io/gh/apache/beam/pull/12764?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12764 +/- ##
===========================================
+ Coverage 40.23% 82.04% +41.81%
===========================================
Files 455 457 +2
Lines 53731 54180 +449
===========================================
+ Hits 21619 44453 +22834
+ Misses 32112 9727 -22385
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/12764?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/typehints/schemas.py](https://codecov.io/gh/apache/beam/pull/12764/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3NjaGVtYXMucHk=)
| `93.20% <86.66%> (+57.61%)` | :arrow_up: |
|
[sdks/python/apache\_beam/coders/row\_coder.py](https://codecov.io/gh/apache/beam/pull/12764/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Jvd19jb2Rlci5weQ==)
| `94.36% <90.90%> (+53.53%)` | :arrow_up: |
|
[sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12764/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=)
| `100.00% <0.00%> (ø)` | |
|
[...he\_beam/testing/benchmarks/nexmark/nexmark\_util.py](https://codecov.io/gh/apache/beam/pull/12764/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya191dGlsLnB5)
| `0.00% <0.00%> (ø)` | |
|
[...eam/testing/benchmarks/nexmark/nexmark\_launcher.py](https://codecov.io/gh/apache/beam/pull/12764/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19sYXVuY2hlci5weQ==)
| `0.00% <0.00%> (ø)` | |
|
[sdks/python/apache\_beam/utils/histogram.py](https://codecov.io/gh/apache/beam/pull/12764/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaGlzdG9ncmFtLnB5)
| `94.28% <0.00%> (ø)` | |
|
[...he\_beam/testing/benchmarks/nexmark/nexmark\_perf.py](https://codecov.io/gh/apache/beam/pull/12764/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19wZXJmLnB5)
| `0.00% <0.00%> (ø)` | |
|
[sdks/python/apache\_beam/coders/slow\_stream.py](https://codecov.io/gh/apache/beam/pull/12764/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Nsb3dfc3RyZWFtLnB5)
| `92.43% <0.00%> (+1.68%)` | :arrow_up: |
|
[sdks/python/apache\_beam/utils/profiler.py](https://codecov.io/gh/apache/beam/pull/12764/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvZmlsZXIucHk=)
| `32.11% <0.00%> (+1.83%)` | :arrow_up: |
|
[...on/apache\_beam/runners/direct/sdf\_direct\_runner.py](https://codecov.io/gh/apache/beam/pull/12764/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3Qvc2RmX2RpcmVjdF9ydW5uZXIucHk=)
| `36.21% <0.00%> (+2.46%)` | :arrow_up: |
| ... and [275
more](https://codecov.io/gh/apache/beam/pull/12764/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/12764?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/12764?src=pr&el=footer). Last
update
[9f4d54a...fcd88ac](https://codecov.io/gh/apache/beam/pull/12764?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 482156)
Time Spent: 4h 10m (was: 4h)
> Support for date times in Python schemas
> ----------------------------------------
>
> Key: BEAM-10009
> URL: https://issues.apache.org/jira/browse/BEAM-10009
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Brian Hulette
> Priority: P3
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> When DATETIME is converted to a MillisInstant logical type, add support for
> it to RowCoder and python schemas.
> Probably we should map MillisInstant to datetime with
> [datetime.datetime.from_timestamp|https://docs.python.org/3/library/datetime.html#datetime.datetime.fromtimestamp]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
