[
https://issues.apache.org/jira/browse/BEAM-10641?focusedWorklogId=482259&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-482259
]
ASF GitHub Bot logged work on BEAM-10641:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Sep/20 19:52
Start Date: 11/Sep/20 19:52
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #12787:
URL: https://github.com/apache/beam/pull/12787#issuecomment-689105076
# [Codecov](https://codecov.io/gh/apache/beam/pull/12787?src=pr&el=h1) Report
> Merging
[#12787](https://codecov.io/gh/apache/beam/pull/12787?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/beam/commit/ba89e76f5daecd496cafb2861dac5ef69480a973?el=desc)
will **increase** coverage by `41.80%`.
> The diff coverage is `71.95%`.
[](https://codecov.io/gh/apache/beam/pull/12787?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12787 +/- ##
===========================================
+ Coverage 40.26% 82.06% +41.80%
===========================================
Files 455 457 +2
Lines 53780 54237 +457
===========================================
+ Hits 21655 44511 +22856
+ Misses 32125 9726 -22399
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/12787?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12787/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==)
| `89.53% <ø> (+65.01%)` | :arrow_up: |
|
[...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12787/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=)
| `77.37% <ø> (+50.00%)` | :arrow_up: |
|
[...s/python/apache\_beam/testing/synthetic\_pipeline.py](https://codecov.io/gh/apache/beam/pull/12787/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9zeW50aGV0aWNfcGlwZWxpbmUucHk=)
| `82.22% <45.23%> (+61.28%)` | :arrow_up: |
|
[.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/12787/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==)
| `88.68% <100.00%> (+75.05%)` | :arrow_up: |
|
[...he\_beam/testing/benchmarks/nexmark/nexmark\_util.py](https://codecov.io/gh/apache/beam/pull/12787/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya191dGlsLnB5)
| `0.00% <0.00%> (ø)` | |
|
[...eam/testing/benchmarks/nexmark/nexmark\_launcher.py](https://codecov.io/gh/apache/beam/pull/12787/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19sYXVuY2hlci5weQ==)
| `0.00% <0.00%> (ø)` | |
|
[sdks/python/apache\_beam/utils/histogram.py](https://codecov.io/gh/apache/beam/pull/12787/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaGlzdG9ncmFtLnB5)
| `94.28% <0.00%> (ø)` | |
|
[...he\_beam/testing/benchmarks/nexmark/nexmark\_perf.py](https://codecov.io/gh/apache/beam/pull/12787/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy9iZW5jaG1hcmtzL25leG1hcmsvbmV4bWFya19wZXJmLnB5)
| `0.00% <0.00%> (ø)` | |
|
[sdks/python/apache\_beam/coders/slow\_stream.py](https://codecov.io/gh/apache/beam/pull/12787/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Nsb3dfc3RyZWFtLnB5)
| `92.43% <0.00%> (+1.68%)` | :arrow_up: |
|
[sdks/python/apache\_beam/utils/profiler.py](https://codecov.io/gh/apache/beam/pull/12787/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvcHJvZmlsZXIucHk=)
| `32.11% <0.00%> (+1.83%)` | :arrow_up: |
| ... and [276
more](https://codecov.io/gh/apache/beam/pull/12787/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/12787?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/12787?src=pr&el=footer). Last
update
[5fd0010...c3dca90](https://codecov.io/gh/apache/beam/pull/12787?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 482259)
Time Spent: 3h 40m (was: 3.5h)
> Add Combiner Packing to Dataflow
> --------------------------------
>
> Key: BEAM-10641
> URL: https://issues.apache.org/jira/browse/BEAM-10641
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Yifan Mai
> Assignee: Yifan Mai
> Priority: P2
> Labels: stale-assigned
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> BEAM-10409 adds a combiner packing graph optimizer for PortableRunner and
> FnApiRunner. We should also add this to the Dataflow runner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
