[
https://issues.apache.org/jira/browse/BEAM-6269?focusedWorklogId=188534&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188534
]
ASF GitHub Bot logged work on BEAM-6269:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/19 23:05
Start Date: 22/Jan/19 23:05
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7316:
[BEAM-6269] Cross-SDK transform expansion protocol.
URL: https://github.com/apache/beam/pull/7316#discussion_r249995295
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SdkComponents.java
##########
@@ -239,10 +273,10 @@ public String getOnlyEnvironmentId() {
}
private String uniqify(String baseName, Set<String> existing) {
- String name = baseName;
+ String name = namespace + baseName;
Review comment:
Unless it is hideously expensive, it might be smart to choose a canonical
meta-format now (that there are three components) and escape the components.
For example slash-separated with slashes internal to the name escaped. This is
mostly a reaction to more strings being concatenated in a way that is starting
to look like it should be real structure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 188534)
Time Spent: 3h 20m (was: 3h 10m)
> Support mixed-language pipelines.
> ---------------------------------
>
> Key: BEAM-6269
> URL: https://issues.apache.org/jira/browse/BEAM-6269
> Project: Beam
> Issue Type: New Feature
> Components: beam-model, runner-core, sdk-java-core, sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Kenneth Knowles
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
