[jira] [Commented] (BEAM-9992) Migrate BeamSQL's SET operators to Sets transforms

[Darshan Jani (Jira)]

    [ 
https://issues.apache.org/jira/browse/BEAM-9992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17195799#comment-17195799
 ] 

Darshan Jani commented on BEAM-9992:
------------------------------------

I tried to write test for schemaCoder, but seems like it works ok.

{code:java}
Schema schema =
            Schema.builder()
                    .addField("a", Schema.FieldType.array(FieldType.BYTES, 
true))
                    .build();

    
    SchemaCoder<Row> schemaCoder = SchemaCoder.of(schema);
        byte[] bytes = {(byte) 0xff};

    Row row = Row.withSchema(schema).addValue(Arrays.asList(bytes, 
null)).build();

    CoderUtils.clone(schemaCoder, row);
{code}

I debugged this and found that at one point of time Schema comes with 
nullable=false even if when it starts it is nullable=true.

I am afraid, I am blocked here. Can we ask someone to help us to debug or find 
the root cause of this problem?


> Migrate BeamSQL's SET operators to Sets transforms
> --------------------------------------------------
>
>                 Key: BEAM-9992
>                 URL: https://issues.apache.org/jira/browse/BEAM-9992
>             Project: Beam
>          Issue Type: New Feature
>          Components: dsl-sql, dsl-sql-zetasql
>            Reporter: Darshan Jani
>            Assignee: Darshan Jani
>            Priority: P2
>              Labels: stale-assigned
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> As par of [BEAM-9946|https://issues.apache.org/jira/browse/BEAM-9946] we have 
> new Sets transforms for intersect,union and except.
> This jira is to use them to remove existing Set operators in BeamSQL code.
> Tasks:
> # Remove: 
> [BeamSetOperatorRelBase.java|https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamSetOperatorRelBase.java]
> # use SetFns transforms from
> ## 
> [BeamIntersectRel.java|https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamIntersectRel.java]
> ## 
> [BeamMinusRel.java|https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamMinusRel.java]
> ## 
> [BeamMinusRel.java|https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamMinusRel.java]
> ## 
> [BeamUnionRel.java|https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamUnionRel.java]
> # 
> Remove:[BeamSetOperatorsTransforms.java|https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamSetOperatorsTransforms.java]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)