[
https://issues.apache.org/jira/browse/BEAM-10620?focusedWorklogId=484505&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-484505
]
ASF GitHub Bot logged work on BEAM-10620:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Sep/20 13:59
Start Date: 15/Sep/20 13:59
Worklog Time Spent: 10m
Work Description: jayendra13 commented on a change in pull request #12540:
URL: https://github.com/apache/beam/pull/12540#discussion_r488690404
##########
File path:
sdks/java/io/common/src/test/java/org/apache/beam/sdk/io/common/IOTestPipelineOptions.java
##########
@@ -45,19 +45,16 @@
void setBigQueryTable(@Nullable String tableName);
@Description("InfluxDB measurement to publish results to.")
- @Nullable
String getInfluxMeasurement();
void setInfluxMeasurement(@Nullable String measurement);
@Description("InfluxDB host.")
- @Nullable
String getInfluxHost();
void setInfluxHost(@Nullable String host);
@Description("InfluxDB database.")
- @Nullable
Review comment:
So these three getters (for measurements, host and database) are fine,
and we should also change these three setters to take `non-null` arguments.
Correct me if I am wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 484505)
Time Spent: 1h 50m (was: 1h 40m)
> Eliminate nullability errors from :sdks:java:extensions:sql:perf-tests
> ----------------------------------------------------------------------
>
> Key: BEAM-10620
> URL: https://issues.apache.org/jira/browse/BEAM-10620
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-sql
> Reporter: Jayendra
> Assignee: Jayendra
> Priority: P2
> Labels: starter
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Just edit {{build.gradle}} and set {{enableChecker: true}} and fix some
> errors!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
