[
https://issues.apache.org/jira/browse/BEAM-10869?focusedWorklogId=484961&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-484961
]
ASF GitHub Bot logged work on BEAM-10869:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Sep/20 06:43
Start Date: 16/Sep/20 06:43
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#12806:
URL: https://github.com/apache/beam/pull/12806#discussion_r489199076
##########
File path: sdks/python/apache_beam/io/gcp/pubsub.py
##########
@@ -299,12 +299,7 @@ def to_proto_str(element):
return element._to_proto_str()
def expand(self, pcoll):
- if self.with_attributes:
- pcoll = pcoll | 'ToProtobuf' >> Map(self.to_proto_str)
-
- # Without attributes, message data is written as-is. With attributes,
- # message data + attributes are passed as a serialized protobuf string (see
- # ``PubsubMessage._to_proto_str`` for exact protobuf message type).
+ pcoll = pcoll | 'ToProtobuf' >> Map(self.to_proto_str)
Review comment:
Update the pydoc for 'with_attributes' property above ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 484961)
Time Spent: 3.5h (was: 3h 20m)
> Pubsub native write should be supported over fnapi
> --------------------------------------------------
>
> Key: BEAM-10869
> URL: https://issues.apache.org/jira/browse/BEAM-10869
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Priority: P2
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
