[
https://issues.apache.org/jira/browse/BEAM-10603?focusedWorklogId=485440&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-485440
]
ASF GitHub Bot logged work on BEAM-10603:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Sep/20 22:33
Start Date: 16/Sep/20 22:33
Worklog Time Spent: 10m
Work Description: rohdesamuel commented on a change in pull request
#12799:
URL: https://github.com/apache/beam/pull/12799#discussion_r489790682
##########
File path: sdks/python/apache_beam/runners/interactive/recording_manager.py
##########
@@ -314,15 +330,55 @@ def cancel(self):
r.wait_until_finish()
self._recordings = set()
+ # The recordings rely on a reference to the BCJ to correctly finish. So we
+ # evict the BCJ after they complete.
+ ie.current_env().evict_background_caching_job(self.user_pipeline)
+
def describe(self):
# type: () -> dict[str, int]
"""Returns a dictionary describing the cache and recording."""
+ cache_manager = ie.current_env().get_cache_manager(self.user_pipeline)
+ capture_size = getattr(cache_manager, 'capture_size', 0)
+
descriptions = [r.describe() for r in self._recordings]
- size = sum(d['size'] for d in descriptions)
- start = min(d['start'] for d in descriptions)
- return {'size': size, 'start': start}
+ if descriptions:
+ size = sum(d['size'] for d in descriptions) + capture_size
+ else:
+ size = capture_size
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 485440)
Time Spent: 31h 10m (was: 31h)
> Large Source Recording for Interarctive Runner
> ----------------------------------------------
>
> Key: BEAM-10603
> URL: https://issues.apache.org/jira/browse/BEAM-10603
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: P1
> Time Spent: 31h 10m
> Remaining Estimate: 0h
>
> This changes the Interactive Runner to create a long-running background
> caching job that is decoupled from the user pipeline. When a user invokes a
> collect() or show(), it will read from the cache to compute the requested
> PCollections. Previously, the user would have to wait for the cache to be
> fully written to. This allows for the user to start experimenting immediately.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
