[
https://issues.apache.org/jira/browse/BEAM-7009?focusedWorklogId=485439&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-485439
]
ASF GitHub Bot logged work on BEAM-7009:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Sep/20 22:33
Start Date: 16/Sep/20 22:33
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #12588:
URL: https://github.com/apache/beam/pull/12588#issuecomment-693700908
No worries. I assumed a conflict would happen somewhere. I'm just glad it
was caught before merging.
Supported/ignored labels/urns would be the way to go, but It does mean
redundancy in the test cases making them a touch harder to add/maintain.
This one was caught out since it's about a feature inside the schema coder
spec that can't be detected by the base URN.
Perhaps a new optional field? Most of them can be caught by the URNs
themselves without special handling but it's the nested feature support
that's trickier to work around (like Go looking up "logical" in the
payload).
On Wed, Sep 16, 2020, 3:26 PM Brian Hulette <[email protected]>
wrote:
> Sorry about that @lostluck <https://github.com/lostluck>, I should've let
> you know about the new test case. There should probably be an easier way
> for SDKs to temporarily opt out of particular tests. WDYT about giving each
> suite labels that SDKs can use in an ignorelist?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/12588#issuecomment-693698195>, or
> unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/ADKDOFOEGXV6FDCALZF6JNDSGE3Q5ANCNFSM4P73YZXQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 485439)
Time Spent: 8h (was: 7h 50m)
> Add Go SDK test for Standard Coders using the yaml data.
> --------------------------------------------------------
>
> Key: BEAM-7009
> URL: https://issues.apache.org/jira/browse/BEAM-7009
> Project: Beam
> Issue Type: Bug
> Components: beam-model, sdk-go
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P1
> Labels: stale-P2
> Time Spent: 8h
> Remaining Estimate: 0h
>
> The Go SDK doesn't currently do this validation, against the standard yaml
> file. [1]
> The Java and Python equivalents of the test can be found from here [2].
>
> Care would need to be taken so that Beam Go SDK users (such as they are)
> aren't forced to run them, and not have the yaml file to read. I'd suggest
> putting it with the integration tests [3].
> The other thing of note is that the Go SDK has no notion of "nested" vs
> "unnested" coders. All coders are "nested" in the Go SDK, and should have
> their lengths prefixed to them as appropriate.
> 1:
> [https://github.com/apache/beam/blob/master/model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml]
> 2:
> [https://github.com/apache/beam/search?q=standard_coders.yaml&unscoped_q=standard_coders.yaml]
> 3: [https://github.com/apache/beam/tree/master/sdks/go/test
> |https://github.com/apache/beam/tree/master/sdks/go/test]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
