[
https://issues.apache.org/jira/browse/BEAM-9547?focusedWorklogId=485807&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-485807
]
ASF GitHub Bot logged work on BEAM-9547:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Sep/20 15:34
Start Date: 17/Sep/20 15:34
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #12857:
URL: https://github.com/apache/beam/pull/12857#discussion_r490019398
##########
File path: sdks/python/apache_beam/dataframe/doctests.py
##########
@@ -316,31 +354,39 @@ def run(self, test, **kwargs):
example.source = 'pass'
example.want = ''
self.skipped += 1
- elif example.exc_msg is None and any(
- wont_implement(example)
- for wont_implement in self._wont_implement_ok.get(test.name, [])):
+ elif example.exc_msg is None and self._is_wont_implement_ok(example,
+ test):
+ # Don't fail doctests that raise this error.
+ example.exc_msg = '%s: ...' % WONT_IMPLEMENT
+ elif example.exc_msg is None and self._is_not_implemented_ok(example,
Review comment:
What about doctests where both wont_implement_error and
not_implemented_ok are True? (On that note, since we're also handling name
errors, does the contents of this really matter anymore?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 485807)
Time Spent: 11h 20m (was: 11h 10m)
> Implement all pandas operations (or raise WontImplementError)
> -------------------------------------------------------------
>
> Key: BEAM-9547
> URL: https://issues.apache.org/jira/browse/BEAM-9547
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Robert Bradshaw
> Priority: P2
> Time Spent: 11h 20m
> Remaining Estimate: 0h
>
> We should have an implementation for every DataFrame, Series, and GroupBy
> method. Everything that's not actually implemented should get a default
> implementation that raises WontImplementError
> See https://github.com/apache/beam/pull/10757#discussion_r389132292
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
