[
https://issues.apache.org/jira/browse/BEAM-10671?focusedWorklogId=485986&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-485986
]
ASF GitHub Bot logged work on BEAM-10671:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Sep/20 22:47
Start Date: 17/Sep/20 22:47
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #12576:
URL: https://github.com/apache/beam/pull/12576#issuecomment-694540273
> I'm a little unsure about the overhead this adds in terms of the number of
options. Would it make sense to instead use the following format? For example:
>
> ```
> --environment_type PROCESS
> --environment_option command=cmd
> --environment_option variable='MY_ENV=XY'
> ```
>
> This would make it more clear what options belong to the environment. The
current state of the PR would look like the following:
>
> ```
> --environment_type PROCESS
> --env_process_command cmd
> --env_process_variable 'MY_ENV=XY'
> ```
>
> My concern is that it is confusing to see the relationship between the
environment type and the options.
I like how this way creates a clearer hierarchy of options. I drafted an
implementation based on how we handle --experiments. If you approve of this
method, I will finish up the documentation work later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 485986)
Time Spent: 4h 20m (was: 4h 10m)
> Add environment configuration fields as first-class pipeline options
> --------------------------------------------------------------------
>
> Key: BEAM-10671
> URL: https://issues.apache.org/jira/browse/BEAM-10671
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-harness
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: P2
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> The pipeline option --environment_config has completely different usages
> depending on the value of --environment_type. This is confusing for the user
> and hard to check. Additionally, --environment_config is a JSON blob for
> --environment_type=PROCESS. This JSON blob is a pain to escape and pass
> around compared to a collection of flat strings.
> We should replace --environment_config with first-class / top-level pipeline
> options for each environment type:
> DOCKER
> --environment_container_image
> PROCESS
> --environment_os
> --environment_architecture
> --environment_variables
> EXTERNAL
> --environment_service_address
> LOOPBACK
> (none)
> This way we can validate that the user is configuring these options correctly
> (ie give a warning or error if they use options that do not apply to their
> chosen --environment_type).
> We can deprecate the --environment_config option, logging a warning until
> removing this option altogether in a future Beam release.
> [https://beam.apache.org/documentation/runtime/sdk-harness-config/]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
