[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=486574&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-486574
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Sep/20 23:15
Start Date: 19/Sep/20 23:15
Worklog Time Spent: 10m
Work Description: chadrik commented on a change in pull request #12881:
URL: https://github.com/apache/beam/pull/12881#discussion_r491596716
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -1070,23 +1078,24 @@ def delayed_bundle_application(self,
return beam_fn_api_pb2.DelayedBundleApplication(
requested_time_delay=proto_deferred_watermark,
application=self.construct_bundle_application(
- op, current_watermark, element_and_restriction))
+ op.input_info, current_watermark, element_and_restriction))
def bundle_application(self,
op, # type: operations.DoOperation
primary # type: SplitResultPrimary
):
# type: (...) -> beam_fn_api_pb2.BundleApplication
- return self.construct_bundle_application(op, None, primary.primary_value)
+ assert op.input_info is not None
+ return self.construct_bundle_application(
+ op.input_info, None, primary.primary_value)
def construct_bundle_application(self,
- op, # type: operations.DoOperation
+ op_input_info, # type:
operations.OpInputInfo
Review comment:
Instead of passing around a `DoOperation` I switched this to a
`OpInputInfo` because the latter is all that we need, and doing so let's us
avoid having to assert that it is not `None` everywhere that it's used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 486574)
Time Spent: 88h (was: 87h 50m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Priority: P3
> Time Spent: 88h
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
