[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=486696&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-486696
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Sep/20 19:05
Start Date: 20/Sep/20 19:05
Worklog Time Spent: 10m
Work Description: chadrik commented on a change in pull request #12881:
URL: https://github.com/apache/beam/pull/12881#discussion_r491722936
##########
File path: sdks/python/apache_beam/runners/worker/log_handler.py
##########
@@ -156,9 +174,11 @@ def _write_log_entries(self):
done = True
log_entries.pop()
if log_entries:
- yield beam_fn_api_pb2.LogEntry.List(log_entries=log_entries)
+ yield beam_fn_api_pb2.LogEntry.List(
+ log_entries=cast(List[beam_fn_api_pb2.LogEntry], log_entries))
Review comment:
we have to cast here because `log_entries` was initialized as a
`List[Union[..., Sentinel]]`, and just above this line we checked for the
sentinel and popped it out, but mypy can't track that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 486696)
Time Spent: 91h 10m (was: 91h)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Priority: P3
> Time Spent: 91h 10m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
