[jira] [Work logged] (BEAM-10933) Dataflow specific pipeline updates are not reflected in the pipeline proto

Mon, 21 Sep 2020 17:57:46 -0700 


     [ 
https://issues.apache.org/jira/browse/BEAM-10933?focusedWorklogId=487374&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-487374
 ]

ASF GitHub Bot logged work on BEAM-10933:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Sep/20 00:56
            Start Date: 22/Sep/20 00:56
    Worklog Time Spent: 10m 
      Work Description: codecov[bot] edited a comment on pull request #12880:
URL: https://github.com/apache/beam/pull/12880#issuecomment-695346831


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12880?src=pr&el=h1) Report
   > Merging 
[#12880](https://codecov.io/gh/apache/beam/pull/12880?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/beam/commit/1b266601c39f243f48dfd085b565b984f936d02c?el=desc)
 will **increase** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/beam/pull/12880/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12880?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #12880   +/-   ##
   =======================================
     Coverage   82.32%   82.32%           
   =======================================
     Files         452      452           
     Lines       54016    54018    +2     
   =======================================
   + Hits        44471    44473    +2     
     Misses       9545     9545           
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/beam/pull/12880?src=pr&el=tree) | Coverage 
Δ | |
   |---|---|---|
   | 
[...on/apache\_beam/runners/dataflow/dataflow\_runner.py](https://codecov.io/gh/apache/beam/pull/12880/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXIucHk=)
 | `77.24% <100.00%> (+0.06%)` | :arrow_up: |
   | 
[sdks/python/apache\_beam/runners/common.py](https://codecov.io/gh/apache/beam/pull/12880/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9jb21tb24ucHk=)
 | `88.75% <0.00%> (-0.45%)` | :arrow_down: |
   | 
[...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12880/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==)
 | `94.18% <0.00%> (-0.27%)` | :arrow_down: |
   | 
[...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12880/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==)
 | `88.80% <0.00%> (-0.18%)` | :arrow_down: |
   | 
[...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/12880/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==)
 | `80.75% <0.00%> (+0.17%)` | :arrow_up: |
   | 
[sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12880/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5)
 | `84.33% <0.00%> (+0.28%)` | :arrow_up: |
   | 
[...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/12880/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==)
 | `89.90% <0.00%> (+1.22%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/beam/pull/12880?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/beam/pull/12880?src=pr&el=footer). Last 
update 
[096f695...83a4d41](https://codecov.io/gh/apache/beam/pull/12880?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 487374)
    Time Spent: 2h 50m  (was: 2h 40m)

> Dataflow specific pipeline updates are not reflected in the pipeline proto
> --------------------------------------------------------------------------
>
>                 Key: BEAM-10933
>                 URL: https://issues.apache.org/jira/browse/BEAM-10933
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow
>            Reporter: Chamikara Madhusanka Jayalath
>            Assignee: Chamikara Madhusanka Jayalath
>            Priority: P2
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> More specifically the to visits here.
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py#L566]
>  
> These have to be done before creating the pipeline proto for Dataflow to be 
> able to correctly generate job requests from portable protos.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to