[
https://issues.apache.org/jira/browse/BEAM-6361?focusedWorklogId=189209&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189209
]
ASF GitHub Bot logged work on BEAM-6361:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jan/19 22:28
Start Date: 23/Jan/19 22:28
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #7408:
[BEAM-6361][BEAM-6364] fix user-metric-prefix checking in Flink portable
metrics update
URL: https://github.com/apache/beam/pull/7408#discussion_r250372569
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/SimpleMonitoringInfoBuilder.java
##########
@@ -112,7 +112,7 @@ private boolean validate() {
if (split.size() != 5) {
LOG.warn(
"Dropping MonitoringInfo for URN {}, UserMetric namespaces and "
- + "name cannot contain ':' characters.",
+ + "names cannot contain ':' characters.",
Review comment:
I think "names cannot contain ':' characters" is actually ok because it
applies to all names.
Here is the full sentence, I'd replace the comma:
"Dropping MonitoringInfo for URN {}. UserMetric namespaces and names cannot
contain ':' characters."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 189209)
Time Spent: 1h 40m (was: 1.5h)
> Fix user-metric prefix detection for portable Flink metrics
> -----------------------------------------------------------
>
> Key: BEAM-6361
> URL: https://issues.apache.org/jira/browse/BEAM-6361
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Affects Versions: 2.9.0
> Reporter: Ryan Williams
> Assignee: Ryan Williams
> Priority: Minor
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> [[email protected]] [noticed a
> bug|https://github.com/apache/beam/pull/7183/files#r243402155] in classifying
> portable Flink metrics as user-namespaced vs not.
> I think it's only currently affecting how metrics get displayed downstream in
> Flink, but it should be fixed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
