[
https://issues.apache.org/jira/browse/BEAM-10844?focusedWorklogId=488711&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-488711
]
ASF GitHub Bot logged work on BEAM-10844:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/20 01:47
Start Date: 23/Sep/20 01:47
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #12727:
URL: https://github.com/apache/beam/pull/12727#discussion_r493136867
##########
File path: sdks/python/apache_beam/transforms/environments.py
##########
@@ -252,6 +254,13 @@ def from_runner_api_parameter(payload, capabilities,
artifacts, context):
@classmethod
def from_options(cls, options):
# type: (PipelineOptions) -> DockerEnvironment
+ if options.view_as(SetupOptions).prebuild_sdk_container_engine:
+ prebuilt_container_image = SdkContainerBuilder.build_container_image(
+ options)
+ return cls.from_container_image(
+ container_image=prebuilt_container_image,
+ artifacts=python_sdk_dependencies(
+ options, skip_boot_dependencies=True))
Review comment:
I meant that `python_sdk_dependencies could` could evaluate whether
`options` has `prebuild_sdk_container_engine` to evaluate what deps to return.
Feel free to keep as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 488711)
Time Spent: 14.5h (was: 14h 20m)
> Add a way to prebuild python sdk container with dependencies
> ------------------------------------------------------------
>
> Key: BEAM-10844
> URL: https://issues.apache.org/jira/browse/BEAM-10844
> Project: Beam
> Issue Type: New Feature
> Components: runner-dataflow
> Reporter: Yichi Zhang
> Assignee: Yichi Zhang
> Priority: P2
> Time Spent: 14.5h
> Remaining Estimate: 0h
>
> We should add a way to prebuild python sdk container on top of latest public
> sdk image, and have all the dependencies installed, so that the setup steps
> won't need to be executed again every time a new worker vm is launched, on
> dataflow.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
