[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=488790&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-488790
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/20 04:10
Start Date: 23/Sep/20 04:10
Worklog Time Spent: 10m
Work Description: chadrik commented on pull request #12884:
URL: https://github.com/apache/beam/pull/12884#issuecomment-696957659
Anything else I should do on this one?
On Mon, Sep 21, 2020 at 9:39 PM Robert Bradshaw <[email protected]>
wrote:
> *@robertwb* approved this pull request.
> ------------------------------
>
> In sdks/python/apache_beam/coders/coder_impl.py
> <https://github.com/apache/beam/pull/12884#discussion_r492465887>:
>
> > @@ -725,7 +728,7 @@ def __init__(self, key_coder_impl,
window_coder_impl):
> self._tag_coder_impl = StrUtf8Coder().get_impl()
>
> def encode_to_stream(self, value, out, nested):
> - # type: (dict, create_OutputStream, bool) -> None
> + # type: (userstate.Timer, create_OutputStream, bool) -> None
>
> Hmm... these probably were right at the time.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/12884#pullrequestreview-493117918>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AAAPOE3FQCUAFBSVMYQRTULSHATARANCNFSM4RTQNRAA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 488790)
Time Spent: 95h 20m (was: 95h 10m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Priority: P3
> Time Spent: 95h 20m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
