[
https://issues.apache.org/jira/browse/BEAM-6457?focusedWorklogId=189290&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189290
]
ASF GitHub Bot logged work on BEAM-6457:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jan/19 03:30
Start Date: 24/Jan/19 03:30
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #7605:
[BEAM-6457] Refactoring of a few BigQuery classes.
URL: https://github.com/apache/beam/pull/7605#discussion_r250455749
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -619,670 +490,11 @@ def format(self):
return 'bigquery'
def writer(self, test_bigquery_client=None, buffer_size=None):
- return BigQueryWriter(
+ return bigquery_tools.BigQueryWriter(
sink=self, test_bigquery_client=test_bigquery_client,
buffer_size=buffer_size)
-# -----------------------------------------------------------------------------
-# BigQueryReader, BigQueryWriter.
-
-
-class BigQueryReader(dataflow_io.NativeSourceReader):
Review comment:
I suggest adding stubs (with warnings) for BigQueryReader (and other public
classes deleted here) as well. We can delete them after few releases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 189290)
Time Spent: 2h 50m (was: 2h 40m)
> bigquery.py is too large, and some tools are better moved elsewhere
> -------------------------------------------------------------------
>
> Key: BEAM-6457
> URL: https://issues.apache.org/jira/browse/BEAM-6457
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Need to do a bit of refactoring of that file
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
