[
https://issues.apache.org/jira/browse/BEAM-10933?focusedWorklogId=489135&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-489135
]
ASF GitHub Bot logged work on BEAM-10933:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/20 04:38
Start Date: 23/Sep/20 04:38
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#12880:
URL: https://github.com/apache/beam/pull/12880#discussion_r492380763
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -488,12 +497,15 @@ def run_pipeline(self, pipeline, options):
# Cross language transform require using a pipeline object constructed
# from the full pipeline proto to make sure that expanded version of
# external transforms are reflected in the Pipeline job graph.
+ # TODO(chamikara): remove following pipeline and pipeline proto
recreation
+ # after portable job submission path is fully in place.
from apache_beam import Pipeline
pipeline = Pipeline.from_runner_api(
self.proto_pipeline,
pipeline.runner,
options,
allow_proto_holders=True)
+ self._adjust_types_for_dataflow(pipeline)
Review comment:
Verified that types are preserved in the pipeline->proto->pipeline
roundtrip and removed this.
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -430,6 +430,11 @@ def _check_for_unsupported_fnapi_features(self,
pipeline_proto):
components.coders[windowing_strategy.window_coder_id].spec.urn,
windowing_strategy.window_fn.urn))
+ def _adjust_types_for_dataflow(self, pipeline):
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 489135)
Time Spent: 5h 20m (was: 5h 10m)
> Dataflow specific pipeline updates are not reflected in the pipeline proto
> --------------------------------------------------------------------------
>
> Key: BEAM-10933
> URL: https://issues.apache.org/jira/browse/BEAM-10933
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Chamikara Madhusanka Jayalath
> Priority: P2
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> More specifically the to visits here.
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py#L566]
>
> These have to be done before creating the pipeline proto for Dataflow to be
> able to correctly generate job requests from portable protos.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
