[
https://issues.apache.org/jira/browse/BEAM-8024?focusedWorklogId=489216&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-489216
]
ASF GitHub Bot logged work on BEAM-8024:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/20 04:44
Start Date: 23/Sep/20 04:44
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on pull request #12899:
URL: https://github.com/apache/beam/pull/12899#issuecomment-696883419
# [Codecov](https://codecov.io/gh/apache/beam/pull/12899?src=pr&el=h1) Report
> Merging
[#12899](https://codecov.io/gh/apache/beam/pull/12899?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/beam/commit/4146e55fd49bd3240135f7675121a21cb071f78a?el=desc)
will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12899?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12899 +/- ##
==========================================
- Coverage 82.33% 82.32% -0.02%
==========================================
Files 453 454 +1
Lines 54040 54061 +21
==========================================
+ Hits 44496 44506 +10
- Misses 9544 9555 +11
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/12899?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/12899/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5)
| `96.49% <0.00%> (-1.76%)` | :arrow_down: |
|
[...dks/python/apache\_beam/runners/pipeline\_context.py](https://codecov.io/gh/apache/beam/pull/12899/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9waXBlbGluZV9jb250ZXh0LnB5)
| `92.80% <0.00%> (-1.01%)` | :arrow_down: |
|
[...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12899/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==)
| `89.53% <0.00%> (-0.21%)` | :arrow_down: |
|
[sdks/python/apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/12899/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=)
| `91.97% <0.00%> (-0.19%)` | :arrow_down: |
|
[...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12899/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==)
| `88.63% <0.00%> (-0.18%)` | :arrow_down: |
|
[...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/12899/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==)
| `94.45% <0.00%> (-0.14%)` | :arrow_down: |
|
[sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/12899/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc25vd2ZsYWtlLnB5)
| `0.00% <0.00%> (ø)` | |
|
[...on/apache\_beam/runners/dataflow/dataflow\_runner.py](https://codecov.io/gh/apache/beam/pull/12899/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXIucHk=)
| `77.24% <0.00%> (+0.06%)` | :arrow_up: |
|
[sdks/python/apache\_beam/runners/common.py](https://codecov.io/gh/apache/beam/pull/12899/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9jb21tb24ucHk=)
| `89.20% <0.00%> (+0.44%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/12899?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/12899?src=pr&el=footer). Last
update
[7f474b5...c262005](https://codecov.io/gh/apache/beam/pull/12899?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 489216)
Time Spent: 3.5h (was: 3h 20m)
> Project importing Beam that uses Java 11 and JPMS cannot compile
> ----------------------------------------------------------------
>
> Key: BEAM-8024
> URL: https://issues.apache.org/jira/browse/BEAM-8024
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Lukasz Gajowy
> Assignee: Kiley Sok
> Priority: P3
> Labels: java11
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> This was suggested on the devlist in a [thread about Java 11
> compatibility|https://lists.apache.org/thread.html/065e7cb9f25a4312ce5f0045ee2946c1d93c04615e37351f1e25a9b8@%3Cdev.beam.apache.org%3E].
>
> I confirmed it in my sandbox project. Source code:
> [https://github.com/lgajowy/beamJava11Compatibility]
> When building this sample project and importing 3 beam dependencies:
> {code:java}
> dependencies {
> compile group: 'org.apache.beam', name: 'beam-sdks-java-core', version:
> '2.14.0'
> compile group: 'org.apache.beam', name: 'beam-runners-direct-java',
> version: '2.14.0'
> compile group: 'org.apache.beam', name:
> 'beam-sdks-java-extensions-google-cloud-platform-core', version: '2.14.0'
> } {code}
>
> It is impossible to compile the project due to split-package problems:
> {code:java}
> error: the unnamed module reads package com.google.common.flogger from both
> flogger and google.extensions
> error: module beam.sdks.java.extensions.google.cloud.platform.core reads
> package com.google.common.flogger from both flogger and google.extensions
> error: module beam.model.pipeline reads package com.google.common.flogger
> from both flogger and google.extensions
> error: module beam.model.job.management reads package
> com.google.common.flogger from both flogger and google.extensions
> error: module beam.vendor.guava.20.0 reads package com.google.common.flogger
> from both flogger and google.extensions
> error: module com.fasterxml.jackson.databind reads package
> com.google.common.flogger from both flogger and google.extensions
> error: module google.auth.library.oauth2.http reads package
> com.google.common.flogger from both flogger and google.extensions
> error: module google.api.services.cloudresourcemanager.v1.rev20181015 reads
> package com.google.common.flogger from both flogger and google.extensions
> error: module gcsio reads package com.google.common.flogger from both flogger
> and google.extensions
> error: module util reads package com.google.common.flogger from both flogger
> and google.extensions
> ...{code}
>
> as stated in the devlist thread, more dependencies can cause problems.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
