[ 
https://issues.apache.org/jira/browse/BEAM-9372?focusedWorklogId=489364&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-489364
 ]

ASF GitHub Bot logged work on BEAM-9372:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Sep/20 04:58
            Start Date: 23/Sep/20 04:58
    Worklog Time Spent: 10m 
      Work Description: codecov[bot] edited a comment on pull request #12911:
URL: https://github.com/apache/beam/pull/12911#issuecomment-697122845


   # [Codecov](https://codecov.io/gh/apache/beam/pull/12911?src=pr&el=h1) Report
   > Merging 
[#12911](https://codecov.io/gh/apache/beam/pull/12911?src=pr&el=desc) into 
[master](https://codecov.io/gh/apache/beam/commit/a4ea68ced3deb4a6e5ae745dedf8ac65740f79ab?el=desc)
 will **decrease** coverage by `0.17%`.
   > The diff coverage is `91.62%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/beam/pull/12911/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1)](https://codecov.io/gh/apache/beam/pull/12911?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12911      +/-   ##
   ==========================================
   - Coverage   82.58%   82.41%   -0.18%     
   ==========================================
     Files         454      454              
     Lines       55403    54337    -1066     
   ==========================================
   - Hits        45757    44781     -976     
   + Misses       9646     9556      -90     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/beam/pull/12911?src=pr&el=tree) | Coverage 
Δ | |
   |---|---|---|
   | 
[sdks/python/apache\_beam/dataframe/frame\_base.py](https://codecov.io/gh/apache/beam/pull/12911/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lX2Jhc2UucHk=)
 | `84.97% <ø> (ø)` | |
   | 
[sdks/python/apache\_beam/io/external/snowflake.py](https://codecov.io/gh/apache/beam/pull/12911/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZXh0ZXJuYWwvc25vd2ZsYWtlLnB5)
 | `0.00% <0.00%> (ø)` | |
   | 
[...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/12911/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5)
 | `96.52% <ø> (-1.01%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/12911/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5)
 | `79.33% <44.44%> (-0.73%)` | :arrow_down: |
   | 
[...s/python/apache\_beam/io/gcp/bigquery\_file\_loads.py](https://codecov.io/gh/apache/beam/pull/12911/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X2ZpbGVfbG9hZHMucHk=)
 | `89.97% <58.33%> (-2.18%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/io/avroio.py](https://codecov.io/gh/apache/beam/pull/12911/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXZyb2lvLnB5)
 | `61.00% <71.42%> (-0.36%)` | :arrow_down: |
   | 
[...dks/python/apache\_beam/runners/pipeline\_context.py](https://codecov.io/gh/apache/beam/pull/12911/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9waXBlbGluZV9jb250ZXh0LnB5)
 | `92.80% <84.61%> (-3.85%)` | :arrow_down: |
   | 
[sdks/python/apache\_beam/dataframe/convert.py](https://codecov.io/gh/apache/beam/pull/12911/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2NvbnZlcnQucHk=)
 | `88.88% <85.71%> (-0.70%)` | :arrow_down: |
   | 
[...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12911/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5)
 | `94.75% <90.90%> (-0.24%)` | :arrow_down: |
   | 
[...python/apache\_beam/examples/wordcount\_dataframe.py](https://codecov.io/gh/apache/beam/pull/12911/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvd29yZGNvdW50X2RhdGFmcmFtZS5weQ==)
 | `91.66% <91.66%> (ø)` | |
   | ... and [39 
more](https://codecov.io/gh/apache/beam/pull/12911/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/beam/pull/12911?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/beam/pull/12911?src=pr&el=footer). Last 
update 
[aa58e1e...93bf1ff](https://codecov.io/gh/apache/beam/pull/12911?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 489364)
    Time Spent: 5h 40m  (was: 5.5h)

> Drop support for Python 3.5
> ---------------------------
>
>                 Key: BEAM-9372
>                 URL: https://issues.apache.org/jira/browse/BEAM-9372
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Valentyn Tymofieiev
>            Assignee: Valentyn Tymofieiev
>            Priority: P0
>             Fix For: 2.25.0
>
>          Time Spent: 5h 40m
>  Remaining Estimate: 0h
>
> Supporting Python 3.5.1, 3.5.2 requires nontrivial amount of work in type 
> inference machinery, but may provide little benefit. Most recently, this 
> surfaced in [1].
> To require Python 3.5.3 and higher we need to migrate Jenkins infrastructure 
> to Python 3.5.3 (see [2]), and update python_requires section in setup.py 
> once we are ready to drop support.
>   
> https://github.com/apache/beam/pull/10821
> https://issues.apache.org/jira/browse/BEAM-8152
> cc: [~udim] [~chadrik]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to