[
https://issues.apache.org/jira/browse/BEAM-5504?focusedWorklogId=489752&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-489752
]
ASF GitHub Bot logged work on BEAM-5504:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/20 18:41
Start Date: 23/Sep/20 18:41
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#12780:
URL: https://github.com/apache/beam/pull/12780#discussion_r493808821
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/DropFields.java
##########
@@ -85,9 +85,8 @@ private Inner(FieldAccessDescriptor fieldsToDrop) {
FieldAccessDescriptor complement(Schema inputSchema, FieldAccessDescriptor
input) {
// Create a FieldAccessDescriptor that select all fields _not_ selected
in the input
- // descriptor. Maintain
- // the original order of the schema.
- Set<String> fieldNamesToSelect = Sets.newHashSet();
+ // descriptor. Maintain the original order of the schema.
+ List<String> fieldNamesToSelect = newArrayList();
Review comment:
Is this fixing a bug where field order isn't maintained? If so we should
break it out into a separate PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 489752)
Time Spent: 8h 10m (was: 8h)
> PubsubAvroTable
> ---------------
>
> Key: BEAM-5504
> URL: https://issues.apache.org/jira/browse/BEAM-5504
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Piotr Szuberski
> Priority: P2
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
