[
https://issues.apache.org/jira/browse/BEAM-10938?focusedWorklogId=489830&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-489830
]
ASF GitHub Bot logged work on BEAM-10938:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/20 20:50
Start Date: 23/Sep/20 20:50
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on pull request #12912:
URL: https://github.com/apache/beam/pull/12912#issuecomment-697965672
# [Codecov](https://codecov.io/gh/apache/beam/pull/12912?src=pr&el=h1) Report
> Merging
[#12912](https://codecov.io/gh/apache/beam/pull/12912?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/beam/commit/dad847069ed37ab060b7e505e0a4251aad547e80?el=desc)
will **increase** coverage by `0.11%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/beam/pull/12912?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12912 +/- ##
==========================================
+ Coverage 82.32% 82.44% +0.11%
==========================================
Files 454 454
Lines 54061 54401 +340
==========================================
+ Hits 44508 44850 +342
+ Misses 9553 9551 -2
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/12912?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/io/textio.py](https://codecov.io/gh/apache/beam/pull/12912/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vdGV4dGlvLnB5)
| `93.30% <100.00%> (+0.23%)` | :arrow_up: |
|
[...am/runners/interactive/options/capture\_limiters.py](https://codecov.io/gh/apache/beam/pull/12912/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9vcHRpb25zL2NhcHR1cmVfbGltaXRlcnMucHk=)
| `90.47% <0.00%> (-3.08%)` | :arrow_down: |
|
[sdks/python/apache\_beam/dataframe/schemas.py](https://codecov.io/gh/apache/beam/pull/12912/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL3NjaGVtYXMucHk=)
| `97.56% <0.00%> (-2.44%)` | :arrow_down: |
|
[...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/12912/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==)
| `88.68% <0.00%> (-1.23%)` | :arrow_down: |
|
[sdks/python/apache\_beam/dataframe/convert.py](https://codecov.io/gh/apache/beam/pull/12912/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2NvbnZlcnQucHk=)
| `88.88% <0.00%> (-0.70%)` | :arrow_down: |
|
[...s/python/apache\_beam/io/gcp/bigquery\_file\_loads.py](https://codecov.io/gh/apache/beam/pull/12912/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5X2ZpbGVfbG9hZHMucHk=)
| `89.97% <0.00%> (-0.63%)` | :arrow_down: |
|
[sdks/python/apache\_beam/io/avroio.py](https://codecov.io/gh/apache/beam/pull/12912/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXZyb2lvLnB5)
| `61.00% <0.00%> (-0.36%)` | :arrow_down: |
|
[...dks/python/apache\_beam/options/pipeline\_options.py](https://codecov.io/gh/apache/beam/pull/12912/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vb3B0aW9ucy9waXBlbGluZV9vcHRpb25zLnB5)
| `94.75% <0.00%> (-0.24%)` | :arrow_down: |
|
[...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/12912/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==)
| `80.57% <0.00%> (-0.18%)` | :arrow_down: |
|
[...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/12912/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==)
| `88.80% <0.00%> (-0.18%)` | :arrow_down: |
| ... and [23
more](https://codecov.io/gh/apache/beam/pull/12912/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/12912?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/12912?src=pr&el=footer). Last
update
[dad8470...6c098a5](https://codecov.io/gh/apache/beam/pull/12912?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 489830)
Time Spent: 50m (was: 40m)
> Update Python WriteToText transform to support writing a footer
> ---------------------------------------------------------------
>
> Key: BEAM-10938
> URL: https://issues.apache.org/jira/browse/BEAM-10938
> Project: Beam
> Issue Type: Improvement
> Components: io-py-files
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Milan Cermak
> Priority: P2
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Seems like this is supported by Java TextIO.Write transform but not Python
> WriteToText transform.
> [https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/io/TextIO.java#L877]
> [https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/textio.py#L582]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
