[ 
https://issues.apache.org/jira/browse/BEAM-7386?focusedWorklogId=489840&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-489840
 ]

ASF GitHub Bot logged work on BEAM-7386:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Sep/20 21:25
            Start Date: 23/Sep/20 21:25
    Worklog Time Spent: 10m 
      Work Description: tysonjh commented on pull request #12915:
URL: https://github.com/apache/beam/pull/12915#issuecomment-697981031


   > Out of curiosity, why are you adding this here instead of the schema join 
library (which SQL uses)?
   
   I wasn't aware of the other join library. I saw the join extension library 
implementations, plus the previously closed PR in BEAM-7386, and thought that 
this new one should be placed near and made the assumption that SQL would reuse 
the implementation. Looking at it now though it seems like the SQL joins don't 
use the join extension library.
   
   Should I keep this one around or refactor into the SQL schema join library?
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 489840)
    Time Spent: 8h 50m  (was: 8h 40m)

> Add Utility BiTemporalStreamJoin
> --------------------------------
>
>                 Key: BEAM-7386
>                 URL: https://issues.apache.org/jira/browse/BEAM-7386
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-ideas
>    Affects Versions: 2.12.0
>            Reporter: Reza ardeshir rokni
>            Priority: P3
>          Time Spent: 8h 50m
>  Remaining Estimate: 0h
>
> Add utility class that enables a temporal join between two streams where 
> Stream A is matched to Stream B where
> A.timestamp = (max(b.timestamp) where b.timestamp <= a.timestamp) 
> This will use the following overall flow:
> KV(key, Timestamped<V>) 
> | Window
> | GBK
> | Statefull DoFn
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to