[
https://issues.apache.org/jira/browse/BEAM-10910?focusedWorklogId=490926&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-490926
]
ASF GitHub Bot logged work on BEAM-10910:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/20 13:26
Start Date: 25/Sep/20 13:26
Worklog Time Spent: 10m
Work Description: milancermak commented on a change in pull request
#12918:
URL: https://github.com/apache/beam/pull/12918#discussion_r494554848
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##########
@@ -131,6 +131,12 @@ def get_hashable_destination(destination):
return destination
+def no_retry_on_invalid_input(exn):
+ if isinstance(exn, ValueError):
+ return False
+ return retry.retry_on_server_errors_and_timeout_filter(exn)
Review comment:
Yeah, I was thinking the same. Looking at the source of retry.py, it
would fit right in (maybe with a better name?). I'm fine with moving it there.
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py
##########
@@ -131,6 +131,12 @@ def get_hashable_destination(destination):
return destination
+def no_retry_on_invalid_input(exn):
+ if isinstance(exn, ValueError):
+ return False
+ return retry.retry_on_server_errors_and_timeout_filter(exn)
Review comment:
I changed it to
`retry_if_valid_input_but_server_error_and_timeout_filter` in the latest
commit. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 490926)
Time Spent: 4.5h (was: 4h 20m)
> Validate the BigQuery table name before creating one
> ----------------------------------------------------
>
> Key: BEAM-10910
> URL: https://issues.apache.org/jira/browse/BEAM-10910
> Project: Beam
> Issue Type: Improvement
> Components: io-py-gcp
> Reporter: Peter Kim
> Assignee: Milan Cermak
> Priority: P4
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Validate the BigQuery tableId before creating a new table with the same name.
> Currently, the error message the user gets when they use an invalid tableId
> (e.g. `table-new`) is too generic:
> >Error message from worker: java.lang.RuntimeException: Failed to create job
> >with prefix
> >beam_load_sciobeamjobkpagratis0914181944742f476e_b08572ba31424693ba2965840dd0e993_ffcc5664fa91525b8e9692df31fd5fce_00001_00000,
> > reached max retries: 3, last failed job: null.
> >org.apache.beam.sdk.io.gcp.bigquery.BigQueryHelpers$PendingJob.runJob(BigQueryHelpers.java:199)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
