[
https://issues.apache.org/jira/browse/BEAM-10891?focusedWorklogId=491361&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-491361
]
ASF GitHub Bot logged work on BEAM-10891:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/20 18:53
Start Date: 25/Sep/20 18:53
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#12837:
URL: https://github.com/apache/beam/pull/12837#discussion_r495155895
##########
File path: website/www/site/content/en/contribute/_index.md
##########
@@ -94,6 +94,11 @@ $ go get github.com/linkedin/goavro
gLinux users should configure their machines for sudoless Docker.
+Alternatively, you can use the
[Dockerfile](https://github.com/apache/beam/blob/master/Dockerfile) to setup a
container meeting the requirements above, and mounting the directory that
contains the Beam repo to the container. e.g.:
Review comment:
```suggestion
Alternatively, you can use the
[Dockerfile](https://github.com/apache/beam/blob/master/Dockerfile) to setup a
container meeting the requirements above, and mount your clone of the Beam repo
to the container. e.g.:
```
##########
File path: website/www/site/content/en/contribute/_index.md
##########
@@ -94,6 +94,11 @@ $ go get github.com/linkedin/goavro
gLinux users should configure their machines for sudoless Docker.
+Alternatively, you can use the
[Dockerfile](https://github.com/apache/beam/blob/master/Dockerfile) to setup a
container meeting the requirements above, and mounting the directory that
contains the Beam repo to the container. e.g.:
+```shell script
+docker run -it --mount
type=bind,source=/Users/jsmith/Desktop/beam,target=/workspaces/beam
<CONTAINER_ID> bash
+```
Review comment:
It would be nice if this also had directions for building the container
and getting the id, something like:
```sh
docker build --rm -t beam-dev ${BEAM_DIR}
set image_id=$(docker images -q beam-dev)
docker run -it --mount type=bind,source=${BEAM_DIR},target=/workspaces/beam
${image_id} bash
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 491361)
Time Spent: 0.5h (was: 20m)
> Dockerfile for development container
> ------------------------------------
>
> Key: BEAM-10891
> URL: https://issues.apache.org/jira/browse/BEAM-10891
> Project: Beam
> Issue Type: Improvement
> Components: website
> Reporter: Omar Ismail
> Assignee: Omar Ismail
> Priority: P2
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Create Dockerfile as alternative to instructions presented inĀ
> https://beam.apache.org/contribute/#prerequisites
--
This message was sent by Atlassian Jira
(v8.3.4#803005)