[
https://issues.apache.org/jira/browse/BEAM-8024?focusedWorklogId=491446&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-491446
]
ASF GitHub Bot logged work on BEAM-8024:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/20 22:05
Start Date: 25/Sep/20 22:05
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#12899:
URL: https://github.com/apache/beam/pull/12899#discussion_r495269114
##########
File path: sdks/java/testing/jpms-tests/build.gradle
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+plugins {
+ id 'org.apache.beam.module'
+}
+javaVersion="1.11"
+applyJavaNature(
+ enableChecker:false,
+ exportJavadoc: false,
+ publish: false,
+ disableLintWarnings: ['requires-transitive-automatic', 'requires-automatic']
+)
+provideIntegrationTestingDependencies()
+enableJavaPerformanceTesting()
+
+description = "Apache Beam :: SDKs :: Java :: Testing :: JPMS Tests"
+ext.summary = "E2E test for Java 9 modules"
+
+dependencies {
+ compile project(path: ":sdks:java:core", configuration: "shadow")
+ compile project(path: ":runners:direct-java")
Review comment:
I believe this would be `runtime` or potentially `testRuntimeOnly`.
If I understand this one correctly right now, it runs the cloned WordCount
on the DirectRunner. You may want to do some of the hacking done
[here](https://github.com/apache/beam/blob/38403698934c422968320a0bdd834e8b9ae598a3/examples/java/build.gradle#L99)
to run it on a variety of runners. I don't know which might (1) be able to run
it or (2) have infrastructures that would make this test check anything
meaningful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 491446)
Time Spent: 5h 40m (was: 5.5h)
> Project importing Beam that uses Java 11 and JPMS cannot compile
> ----------------------------------------------------------------
>
> Key: BEAM-8024
> URL: https://issues.apache.org/jira/browse/BEAM-8024
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Lukasz Gajowy
> Assignee: Kiley Sok
> Priority: P3
> Labels: java11
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> This was suggested on the devlist in a [thread about Java 11
> compatibility|https://lists.apache.org/thread.html/065e7cb9f25a4312ce5f0045ee2946c1d93c04615e37351f1e25a9b8@%3Cdev.beam.apache.org%3E].
>
> I confirmed it in my sandbox project. Source code:
> [https://github.com/lgajowy/beamJava11Compatibility]
> When building this sample project and importing 3 beam dependencies:
> {code:java}
> dependencies {
> compile group: 'org.apache.beam', name: 'beam-sdks-java-core', version:
> '2.14.0'
> compile group: 'org.apache.beam', name: 'beam-runners-direct-java',
> version: '2.14.0'
> compile group: 'org.apache.beam', name:
> 'beam-sdks-java-extensions-google-cloud-platform-core', version: '2.14.0'
> } {code}
>
> It is impossible to compile the project due to split-package problems:
> {code:java}
> error: the unnamed module reads package com.google.common.flogger from both
> flogger and google.extensions
> error: module beam.sdks.java.extensions.google.cloud.platform.core reads
> package com.google.common.flogger from both flogger and google.extensions
> error: module beam.model.pipeline reads package com.google.common.flogger
> from both flogger and google.extensions
> error: module beam.model.job.management reads package
> com.google.common.flogger from both flogger and google.extensions
> error: module beam.vendor.guava.20.0 reads package com.google.common.flogger
> from both flogger and google.extensions
> error: module com.fasterxml.jackson.databind reads package
> com.google.common.flogger from both flogger and google.extensions
> error: module google.auth.library.oauth2.http reads package
> com.google.common.flogger from both flogger and google.extensions
> error: module google.api.services.cloudresourcemanager.v1.rev20181015 reads
> package com.google.common.flogger from both flogger and google.extensions
> error: module gcsio reads package com.google.common.flogger from both flogger
> and google.extensions
> error: module util reads package com.google.common.flogger from both flogger
> and google.extensions
> ...{code}
>
> as stated in the devlist thread, more dependencies can cause problems.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
