[
https://issues.apache.org/jira/browse/BEAM-4620?focusedWorklogId=189647&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189647
]
ASF GitHub Bot logged work on BEAM-4620:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jan/19 19:45
Start Date: 24/Jan/19 19:45
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #7555:
[BEAM-4620] UnboundedReadFromBoundedSource invokes split for small bounded
sources
URL: https://github.com/apache/beam/pull/7555#discussion_r250752064
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/UnboundedReadFromBoundedSource.java
##########
@@ -127,9 +131,11 @@ public void validate() {
long desiredBundleSize = boundedSource.getEstimatedSizeBytes(options)
/ desiredNumSplits;
if (desiredBundleSize <= 0) {
LOG.warn(
- "BoundedSource {} cannot estimate its size, skips the initial
splits.",
Review comment:
Your comment makes sense. To make matters more complicated our API instructs
source authors to return 0L if size of source cannot be determined.
So I updated code to pick a default size of 64MB in case 0 is returned as
the estimated source. Otherwise we'll try to maximize splitting by setting
desiredBindleSize to 1 when a valid value cannot be determined.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 189647)
Time Spent: 40m (was: 0.5h)
> UnboundedReadFromBoundedSource.split() should always call split()
> -----------------------------------------------------------------
>
> Key: BEAM-4620
> URL: https://issues.apache.org/jira/browse/BEAM-4620
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Josh M
> Assignee: Chamikara Jayalath
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> If the source contains too little data (rounds the result down to 0), or if
> size estimation fails, then we don't call .split(). We must always call
> split(); instead of returning original source, we should have computed some
> fallback value for desiredBundleSize.
> This bug has existed since the code was first introduced, so it is not a
> regression - but it is certainly a bug.
>
> source:
> https://github.com/apache/beam/blob/697a1d17e473cd5b097aaaeee24c08f43cc77f58/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/UnboundedReadFromBoundedSource.java#L137
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
