[
https://issues.apache.org/jira/browse/BEAM-10892?focusedWorklogId=492424&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-492424
]
ASF GitHub Bot logged work on BEAM-10892:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Sep/20 12:44
Start Date: 29/Sep/20 12:44
Worklog Time Spent: 10m
Work Description: piotr-szuberski edited a comment on pull request #12838:
URL: https://github.com/apache/beam/pull/12838#issuecomment-700676777
There is a problem here though. The checker says to use vendored proto
library but the extensions/protobuf uses the normal one. How is that possible
that it's fine there and it's a bug in extensions/sql?
And for example ProtoCoder<T> requires T to extend
com.google.protobuf.Message while this is forbidden.
Should I create another PR replacing normal protobuf library with the
vendored one in extensions/protobuf or is there a reason not to use vendored
grpc library there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 492424)
Time Spent: 1h 50m (was: 1h 40m)
> Add Proto support to Kafka Table Provider
> -----------------------------------------
>
> Key: BEAM-10892
> URL: https://issues.apache.org/jira/browse/BEAM-10892
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql
> Reporter: Piotr Szuberski
> Assignee: Piotr Szuberski
> Priority: P2
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
