[
https://issues.apache.org/jira/browse/BEAM-10956?focusedWorklogId=492654&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-492654
]
ASF GitHub Bot logged work on BEAM-10956:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Sep/20 20:20
Start Date: 29/Sep/20 20:20
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on pull request #12967:
URL: https://github.com/apache/beam/pull/12967#issuecomment-700964375
# [Codecov](https://codecov.io/gh/apache/beam/pull/12967?src=pr&el=h1) Report
> Merging
[#12967](https://codecov.io/gh/apache/beam/pull/12967?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/beam/commit/967d7288cd5069f21617c98a9156dd4076bb9fb9?el=desc)
will **decrease** coverage by `0.12%`.
> The diff coverage is `93.97%`.
[](https://codecov.io/gh/apache/beam/pull/12967?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12967 +/- ##
==========================================
- Coverage 82.45% 82.33% -0.13%
==========================================
Files 454 455 +1
Lines 54607 54650 +43
==========================================
- Hits 45028 44997 -31
- Misses 9579 9653 +74
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/12967?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[...pache\_beam/runners/interactive/interactive\_beam.py](https://codecov.io/gh/apache/beam/pull/12967/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9iZWFtLnB5)
| `79.53% <89.47%> (+0.51%)` | :arrow_up: |
|
[...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/12967/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==)
| `89.45% <97.05%> (+0.02%)` | :arrow_up: |
|
[sdks/python/apache\_beam/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/12967/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vX19pbml0X18ucHk=)
| `85.71% <100.00%> (ø)` | |
|
[...ache\_beam/runners/interactive/recording\_manager.py](https://codecov.io/gh/apache/beam/pull/12967/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9yZWNvcmRpbmdfbWFuYWdlci5weQ==)
| `98.90% <100.00%> (-0.17%)` | :arrow_down: |
|
[.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/12967/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5)
| `88.63% <0.00%> (-4.55%)` | :arrow_down: |
|
[...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/12967/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=)
| `90.90% <0.00%> (-1.82%)` | :arrow_down: |
|
[sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/12967/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5)
| `83.75% <0.00%> (-0.58%)` | :arrow_down: |
|
[sdks/python/apache\_beam/runners/common.py](https://codecov.io/gh/apache/beam/pull/12967/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9jb21tb24ucHk=)
| `88.75% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [24
more](https://codecov.io/gh/apache/beam/pull/12967/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/12967?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/12967?src=pr&el=footer). Last
update
[1a09a75...c5225bd](https://codecov.io/gh/apache/beam/pull/12967?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 492654)
Time Spent: 1.5h (was: 1h 20m)
> PipelineInstrumentTest is flaky
> -------------------------------
>
> Key: BEAM-10956
> URL: https://issues.apache.org/jira/browse/BEAM-10956
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: P2
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> h3. Error Message
> AttributeError: 'Pipeline' object has no attribute 'pipeline'
> h3. Stacktrace
> self =
> <apache_beam.runners.interactive.pipeline_instrument_test.PipelineInstrumentTest
> testMethod=test_pipeline_pruned_when_input_pcoll_is_cached> def
> test_pipeline_pruned_when_input_pcoll_is_cached(self): > user_pipeline,
> init_pcoll, _ = self._example_pipeline()
> apache_beam/runners/interactive/pipeline_instrument_test.py:765: _ _ _ _ _ _
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> apache_beam/runners/interactive/pipeline_instrument_test.py:223: in
> _example_pipeline ie.current_env().set_cache_manager(InMemoryCache(), p)
> apache_beam/runners/interactive/interactive_environment.py:324: in
> set_cache_manager self.cleanup(pipeline)
> apache_beam/runners/interactive/interactive_environment.py:277: in cleanup
> self.evict_computed_pcollections(pipeline) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ self =
> <apache_beam.runners.interactive.interactive_environment.InteractiveEnvironment
> object at 0x7f8698c89cf8> pipeline = <apache_beam.pipeline.Pipeline object
> at 0x7f86cc1539e8> def evict_computed_pcollections(self, pipeline=None):
> """Evicts all computed PCollections for the given pipeline. If no pipeline is
> specified, evicts for all pipelines. """ if pipeline: discarded = set() for
> pcoll in self._computed_pcolls: > if pcoll.pipeline is pipeline: E
> AttributeError: 'Pipeline' object has no attribute 'pipeline'
> apache_beam/runners/interactive/interactive_environment.py:506: AttributeError
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
