[
https://issues.apache.org/jira/browse/BEAM-8665?focusedWorklogId=492826&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-492826
]
ASF GitHub Bot logged work on BEAM-8665:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Sep/20 08:06
Start Date: 30/Sep/20 08:06
Worklog Time Spent: 10m
Work Description: TobKed commented on a change in pull request #12318:
URL: https://github.com/apache/beam/pull/12318#discussion_r497319272
##########
File path: sdks/python/apache_beam/runners/portability/stager_test.py
##########
@@ -167,6 +167,9 @@ def test_no_main_session(self):
# xdist adds unpicklable modules to the main session.
@pytest.mark.no_xdist
+ @pytest.mark.skip(
+ sys.platform == 'win32',
+ "Windows raise TypeError: can't pickle zipimport.zipimporter objects")
Review comment:
I see it this skip was not included in
https://github.com/apache/beam/pull/12452.
As far i remember after some rebasings and further work on the tests it
started to work and for many test runs it didn't fail so I removed this skip.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 492826)
Time Spent: 1h 20m (was: 1h 10m)
> Add infrastructure + test suites to run Beam tests on Windows/Mac platforms.
> -----------------------------------------------------------------------------
>
> Key: BEAM-8665
> URL: https://issues.apache.org/jira/browse/BEAM-8665
> Project: Beam
> Issue Type: Test
> Components: testing
> Reporter: Valentyn Tymofieiev
> Priority: P3
> Labels: beam-fixit
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
