[
https://issues.apache.org/jira/browse/BEAM-10114?focusedWorklogId=493101&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-493101
]
ASF GitHub Bot logged work on BEAM-10114:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Sep/20 18:11
Start Date: 30/Sep/20 18:11
Worklog Time Spent: 10m
Work Description: boyuanzz commented on a change in pull request #12957:
URL: https://github.com/apache/beam/pull/12957#discussion_r497706527
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/TranslatingPullSubscriber.java
##########
@@ -17,12 +17,28 @@
*/
package org.apache.beam.sdk.io.gcp.pubsublite;
+import com.google.cloud.pubsublite.internal.PullSubscriber;
import com.google.cloud.pubsublite.proto.SequencedMessage;
import io.grpc.StatusException;
import java.util.List;
+import java.util.stream.Collectors;
-/** A PullSubscriber exposes a "pull" mechanism for retrieving messages. */
-interface PullSubscriber extends AutoCloseable {
- /** Pull currently available messages from this subscriber. Does not block.
*/
- List<SequencedMessage> pull() throws StatusException;
+class TranslatingPullSubscriber implements PullSubscriber<SequencedMessage> {
Review comment:
Please add some javadoc for this class. Other than that, changes look
good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 493101)
Time Spent: 9.5h (was: 9h 20m)
> Add Pub/Sub Lite IO to beam builtin
> -----------------------------------
>
> Key: BEAM-10114
> URL: https://issues.apache.org/jira/browse/BEAM-10114
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
> Reporter: Daniel Collins
> Priority: P3
> Time Spent: 9.5h
> Remaining Estimate: 0h
>
> The IO currently lives [on the pubsub lite
> github|[https://github.com/googleapis/java-pubsublite/tree/master/pubsublite-beam-io]]
> but should be moved to being part of beam.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
