[
https://issues.apache.org/jira/browse/BEAM-7505?focusedWorklogId=493389&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-493389
]
ASF GitHub Bot logged work on BEAM-7505:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Oct/20 10:12
Start Date: 01/Oct/20 10:12
Worklog Time Spent: 10m
Work Description: kamilwu commented on a change in pull request #11856:
URL: https://github.com/apache/beam/pull/11856#discussion_r498133642
##########
File path: sdks/python/apache_beam/testing/load_tests/sideinput_test.py
##########
@@ -122,85 +122,95 @@ def process(self, unused_element, side_input):
# No-op. We only make sure that the element is accessed.
next(it)
except StopIteration:
- return
+ break
class MappingSideInputTestDoFn(beam.DoFn):
Review comment:
Ok.
Since we don't support Python 2 anymore, I decided to use Python 3
annotations which are slightly better than class decorators
(@typehints.with_input_types and @typehints.with_output_types)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 493389)
Time Spent: 14.5h (was: 14h 20m)
> Create SideInput Python Load Test Jenkins Job
> ---------------------------------------------
>
> Key: BEAM-7505
> URL: https://issues.apache.org/jira/browse/BEAM-7505
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Kasia Kucharczyk
> Assignee: Kamil Wasilewski
> Priority: P2
> Time Spent: 14.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
