[
https://issues.apache.org/jira/browse/BEAM-6324?focusedWorklogId=189904&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189904
]
ASF GitHub Bot logged work on BEAM-6324:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jan/19 08:55
Start Date: 25/Jan/19 08:55
Worklog Time Spent: 10m
Work Description: timrobertson100 commented on pull request #7340:
[BEAM-6324] - Cassandra reader with query implemented
URL: https://github.com/apache/beam/pull/7340#discussion_r250907026
##########
File path:
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraServiceImpl.java
##########
@@ -237,37 +237,44 @@ static long getEstimatedSizeBytes(List<TokenRange>
tokenRanges) {
for (List<RingRange> split : splits) {
List<String> queries = new ArrayList<>();
for (RingRange range : split) {
- Select.Where builder = QueryBuilder.select().from(spec.keyspace(),
spec.table()).where();
if (range.isWrapping()) {
- // A wrapping range is one that overlaps from the end of the
partitioner range and its
+ // A wrapping range is one that overlaps from the end of the
partitioner range
+ // and its
// start (ie : when the start token of the split is greater than the
end token)
Review comment:
Nit: please correct line breaks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 189904)
Time Spent: 50m (was: 40m)
> CassandraIO.Read - Add the ability to provide a filter to the query
> -------------------------------------------------------------------
>
> Key: BEAM-6324
> URL: https://issues.apache.org/jira/browse/BEAM-6324
> Project: Beam
> Issue Type: Improvement
> Components: io-java-cassandra
> Affects Versions: 2.9.0
> Reporter: Shahar Frank
> Assignee: Shahar Frank
> Priority: Major
> Labels: performance, pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> CassandraIO.Read doesn't support using WHERE to filter the input at the
> source (In Cassandra) which might provide great performance boost.
> Already implemented by:
> https://github.com/apache/beam/pull/7340
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
