[
https://issues.apache.org/jira/browse/BEAM-10994?focusedWorklogId=493701&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-493701
]
ASF GitHub Bot logged work on BEAM-10994:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Oct/20 21:40
Start Date: 01/Oct/20 21:40
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #12983:
URL: https://github.com/apache/beam/pull/12983#discussion_r498526932
##########
File path:
runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptionsTest.java
##########
@@ -243,5 +243,12 @@ public void testDefaultGcpRegionFromGcloud() throws
IOException, InterruptedExce
DataflowPipelineOptions options =
PipelineOptionsFactory.as(DataflowPipelineOptions.class);
assertEquals("us-west1", options.getRegion());
}
+
+ @Test
+ public void testHotKeyLoggingEnabled() {
+ DataflowPipelineOptions options =
PipelineOptionsFactory.as(DataflowPipelineOptions.class);
+ options.setHotKeyLoggingEnabled(true);
+ assertEquals(true, options.getHotKeyLoggingEnabled());
+ }
Review comment:
I don't believe there is value in testing this as
PipelineOptionsFactoryTest covers these kinds of tests.
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 493701)
Time Spent: 1h 10m (was: 1h)
> Add Hot Key Logging in Dataflow Runner
> --------------------------------------
>
> Key: BEAM-10994
> URL: https://issues.apache.org/jira/browse/BEAM-10994
> Project: Beam
> Issue Type: New Feature
> Components: runner-dataflow
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: P2
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This adds the ability for users to enable the logging of hot key content.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
